Closed Bug 480479 Opened 15 years ago Closed 15 years ago

TM: permit and guard on dense arrays when tracing a not-found property acccess

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: gal, Assigned: gal)

Details

(Keywords: verified1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

v2
5.99 KB, patch
Waldo
: review+
Details | Diff | Splinter Review 
SS's 3d-raytrace likes to ask dense arrays repeatedly just how much they don't have a certain property.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: general → gal

    
  

        Attachment #364469 -
        Flags: review?(jwalden+bmo)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2
        — 
          — Splinter Review
      

    


  

        Attachment #364469 -
        Attachment is obsolete: true

        Attachment #364470 -
        Flags: review?

        Attachment #364469 -
        Flags: review?(jwalden+bmo)

    
  

        Attachment #364470 -
        Flags: review? → review?(jwalden+bmo)

    
  

        Attachment #364470 -
        Flags: review?(jwalden+bmo) → review+

    
    

    
  
Comment on attachment 364470 [details] [diff] [review]
v2

Add some trace-tests for not aborting recording on these access-undefined cases, and make sure we side exit and record correctly afterward, please.  With that, r=me.

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/0f98a48e008d
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/0f98a48e008d
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: wanted1.9.1+
Resolution: --- → FIXED

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/1c16405d7d6c
/cvsroot/mozilla/js/tests/js1_8_1/trace/trace-test.js,v  <--  trace-test.js
new revision: 1.12; previous revision: 1.11
Flags: in-testsuite+

    
    

    
  
verified 1.9.1, 1.9.2 based on testUndefinedPropertyAccess
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: