480480 - Finding cluster with api/register/chknode has trailing newline

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Ed Lee :Mardak]

$ curl https://auth.services.mozilla.com/0.3/api/register/chknode/harikaried
sj-weave01.services.mozilla.com
$ 

Notice the next prompt $ starts on its own line. This is causing problems with the generated clusterURL because now it's...

https://sj-weave01.services.mozilla.com
/

Not sure what's going on for the server, but we can work around it on the client by just doing res.data.trim()

Comment 1

[Ed Lee :Mardak]

Pushed a workaround for now. I'll leave the bug open for figuring out why the newline is there to begin with.

http://hg.mozilla.org/labs/weave/rev/dce3e928fc11

Comment 2

[Dan Mills [:thunder]]

FYI, we have plans to change what the server returns to be a URL instead of a domain name.

Comment 3

[Toby Elliott [:telliott]]

Adding Jeremy so that he can fix the current servers.

Comment 4

[Jeremy Orem [:oremj]]

Newline has been removed.

Comment 5

[Ed Lee :Mardak]

Marking fixed per comment #4 and testing with curl shows no newline. I suppose we can just leave the workaround for now?

Comment 6

[Dan Mills [:thunder]]

Yeah, it doesn't really matter either way.
We'll want to parse full URLs in the future, probably.

Comment 7

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/561603ff8747
Remove trailing newline bug 480480  work-around: trim().