480497 - [c3d] getImageData missing

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ilmari Heikkinen]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2a1pre) Gecko/20090226 Minefield/3.2a1pre
Build Identifier: 

There's no getImageData implementation in the 3d canvas. GetImageData should read from the visible image on the pbuffer surface. 


Reproducible: Always

Steps to Reproduce:
1. gl.getImageData(0,0,1,1)

Actual Results:  
Error, no getImageData method.

Expected Results:  
Should have returned an imagedata object {width:1, height:1, data:[r,g,b,a]}.

Comment 1

[Ilmari Heikkinen]

Attachment: Patch that adds getImageData and implements GetInputStream

Implementations for GetImageData and GetInputStream adapted
from nsCanvasRenderingContext2D.cpp

ToDataURL doesn't work, probably because ToDataURLImpl in
content/html/content/src/nsHTMLCanvasElement.cpp
has the 2D context assumption hardcoded
( GetContext(NS_LITERAL_STRING("2d"), getter_AddRefs(context)) )

Comment 2

[Ilmari Heikkinen]

Attachment: Testcase for gl.getImageData [and FBOs and gl.readPixels and a failing toDataURL test]

Comment 3

[Ilmari Heikkinen]

Attachment: Updated patch, depends on the glReadPixels patch for CheckSaneSubrectSize

Comment 4

[Ilmari Heikkinen]

Attachment: reduction of the bigger test

Comment 5

[Ilmari Heikkinen]

Comment on attachment 365146 [details] [diff] [review]
Updated patch, depends on the glReadPixels patch for CheckSaneSubrectSize

Argh, GetInputStream doesn't use OPERATOR_SOURCE, so you get garbled data.

Comment 6

[Ilmari Heikkinen]

Attachment: Now does GetInputStream compositing with OPERATOR_SOURCE

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

getImageData doesn't exist in the current WebGL spec.