480498 - After update that requires server wipe only one entry in client list

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P1)

Description

[Peter Staev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2 (.NET CLR 3.5.30729)
Build Identifier: 0.2.106

After an update that requires a server wipe, the client list gets incossistent. On the first computer that does the sync there is only one entry (the entry for itself) and on the second computer there are both entries for the first and second computer. 

Reproducible: Always

Steps to Reproduce:
1. Upgrade Computer1
2. Copmuter1 uploads Client record for himself (OK)
3. Upgrade Computer2
4. Computer2 does not upload hist client record to the server
Actual Results:  
Copmuter2 does not upload hist client record to the server

Expected Results:  
Computer should upload his client record to the server, so the clietn list will be conssistent

Reading the logs, only the first computer uploads the client list. On the second computer in the log, just after the server wipe was detected stays: 

2009-02-27 09:01:09	Service.Main	INFO	Cleared local caches after server wipe was detected
2009-02-27 09:01:11	Engine.Clients	INFO	0 outgoing items pre-reconciliation

Updating the client type (Desktop, Laptop, etc) on the second computer made the record to sync correctly

Comment 2

[darius]

I seem to have slightly different behavior with 0.2.110.  I have two Macs (one desktop, one laptop) synchronizing successfully using
Weave.

In the Weave Clients tab where it lists "Computers that are synchronizing with
this Weave account:" only one client is listed. My desktop client only lists
itself, and my laptop client only lists itself.

So in other words, each client sees only one record, itself.

Comment 3

[Ed Lee :Mardak]

I don't see this behavior on my profile (just upgraded from 0.2.110 to 0.2.111). Both clients show each other.

Do the logs show anything about clients data not being able to sync?

Comment 4

[darius]

Updated to 0.2.111, same behavior of each client only listing itself.  Laptop sees laptop only, desktop sees desktop only, but I just made a bunch of bookmark changes on the desktop and all the changes showed up on the laptop with the next sync.

Clients appear to work fine, logs attached.

Comment 5

[darius]

Ok, didn't attach logs as they seem to have stuff in them that I don't want on the Internet.  Anything I can cut/paste specifically that might help?  No obvious error messages anywhere.

Comment 6

[Ed Lee :Mardak]

Entries that relate to the Clients engine would be useful:
Engine.Clients, ClientTracker, Store.Clients.Store

as well as RecordMgr and Net.Resource that are close to those entries such as..

2009-03-10 08:22:30	Net.Resource         DEBUG	GET request for  https://sj-weave01.services.mozilla.com/0.3/user/yourusername/crypto/clients

Comment 7

[Dan Mills [:thunder]]

I could've sworn I fixed this, but after spending a while looking at the hg log I can't find where I did it.  This is as close as I get:

http://hg.mozilla.org/labs/weave/rev/da5cffcb6d19

And that would've caused the above behavior, but that fix was in 0.2.108.

Comment 8

[darius]

Attachment: Parts of Weave Sync.log on Mac desktop client

Comment 9

[darius]

Attachment: Parts of Weave Sync.log on Mac laptop client

Comment 10

[darius]

Ok, I've uploaded the parts of my Weave Sync.log files from the two clients that only show themselves in the clients list.

Comment 11

[Dan Mills [:thunder]]

(In reply to comment #10)
> Ok, I've uploaded the parts of my Weave Sync.log files from the two clients
> that only show themselves in the clients list.

Thanks.  But unfortunately, both your clients think they are already fully synced-up.  You can see that here:

Engine.Clients       INFO	Applied 0 records, reconciled 0 records
Engine.Clients       DEBUG	Preparing 0 outgoing records

The real question is what gets uploaded/downloaded on a fresh sync.  You can trigger a full server wipe & re-sync by deleting the metadata record with e.g. curl, see this forum post for how to do that:

https://labs.mozilla.com/forum/comments.php?DiscussionID=5127&page=1

Comment 12

[Peter Staev]

OK, with this update (0.2.111) i do not experience the above mentioned problem.

Comment 13

[darius]

Attachment: Parts of Weave Sync.log on Mac desktop client

Comment 14

[darius]

Attachment: Parts of Weave Sync.log on Mac laptop client (with other problems?)

Ok, clearly something else is also wrong, now there is a repeated error on the laptop since wiping the server data.  I've not seen this error before.

Both clients, however, still see only themselves.

Comment 15

[Dan Mills [:thunder]]

Could not process incoming record: ... (NS_ERROR_FAILURE) [IWeaveCrypto.decrypt]

This probably means you typed an incorrect passphrase.  Weave is very un-graceful about that at the moment.  You will probably need to log out on all clients, then do a full server wipe to recover from this state.

Comment 16

[Dan Mills [:thunder]]

These commits should fix this bug:

http://hg.mozilla.org/labs/weave/rev/e816128ecc7d
http://hg.mozilla.org/labs/weave/rev/7386c859c0d5

It's working well for me, now.