Created attachment 364512 [details] [diff] [review] Makes nsHTMLCanvasElement::ToDataURLImpl use mCurrentContextId for getting the context to read from Makes toDataURL work for non-2d contexts.
Comment on attachment 364512 [details] [diff] [review] Makes nsHTMLCanvasElement::ToDataURLImpl use mCurrentContextId for getting the context to read from Thanks for catching this.. also feel free to set review? on me (:vlad) on patches that are ready to go, and I'll give them a look over :) This looks fine, though I'm wondering what we should do if there's no attached context to the canvas. I'd probably rather throw an error, so maybe check is mCurrentContextId.IsEmpty() and just return NS_ERROR_FAILURE... then mCurrentContextId can be used instead of ctxId.
Created attachment 364687 [details] [diff] [review] context id fix, now errors if there's no current context id
what's the status of this? is this a dup with 528042 ?
Yeah, this is a dup.