Recut CTA graphics, make Learn More graphic work in IE 6

VERIFIED FIXED in 3.0

Status

VERIFIED FIXED
10 years ago
7 years ago

People

(Reporter: neilio, Assigned: neilio)

Tracking

unspecified
x86
Windows XP

Details

(Whiteboard: style)

Attachments

(5 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
New bug to track multiple fixes to the CTA area.
(Assignee)

Comment 1

10 years ago
Created attachment 364561 [details] [diff] [review]
Improved CTA graphics, redid the learn more graphic so it renders correctly in IE 6 (old one was PNG24), and some alignment fixes
Attachment #364561 - Flags: review?(buchanae)
(Assignee)

Comment 2

10 years ago
Created attachment 364563 [details]
New images referenced by this patch
Attachment #364563 - Flags: review?(buchanae)
OS: Mac OS X → Windows XP
Comment on attachment 364561 [details] [diff] [review]
Improved CTA graphics, redid the learn more graphic so it renders correctly in IE 6 (old one was PNG24), and some alignment fixes

everything looks OK to me
Attachment #364561 - Flags: review?(buchanae) → review+
Attachment #364563 - Flags: review?(buchanae) → review+
Comment on attachment 364561 [details] [diff] [review]
Improved CTA graphics, redid the learn more graphic so it renders correctly in IE 6 (old one was PNG24), and some alignment fixes

actually, sorry I confused myself.  The Learn more link looks screwy on FF3 for me.  screenshot to follow
Attachment #364561 - Flags: review+ → review-
Attachment #364563 - Flags: review+ → review-
Created attachment 366696 [details]
new image funk

this shows my dev homepage with patches from attachments 364561 and 364563 applied.  The Learn More images are funky and if you look closely, there is a small, vertical, white line to the left of the Learn More in the Spread block
(Assignee)

Comment 6

10 years ago
Created attachment 366718 [details]
Fixed image

Ah, good eye! This image fixes the issue.
Attachment #366718 - Flags: review?(buchanae)
(Assignee)

Comment 7

10 years ago
Note that the Learn More graphic isn't going to be the clearest because it needs to work in IE, so I couldn't use a PNG24. The only other way to fix this is to have separate Learn More images for each box with that box's background colour, which is kind of overkill imo.
(In reply to comment #7)
> Note that the Learn More graphic isn't going to be the clearest because it
> needs to work in IE, so I couldn't use a PNG24. The only other way to fix this
> is to have separate Learn More images for each box with that box's background
> colour, which is kind of overkill imo.

The new learn more images are really shotty though.  Not sure what the best solution is, but the new images won't do.  

Can we get better quality without using PNG24?  I assume the underlying problem is that IE 6 doesn't support PNG transparency?

Can we do this with text only?  Drop the learn more images altogether?

I agree, having different images per background color is lame, but if it get's everyone the best quality for now (on our short schedule) until we figure out how to do it better (or drop IE6), and we only have to add 4 images, that sounds like the best approach to me.

There is a JS hack for IE/PNG transparency, although that sounds time-costly.

Comment 9

10 years ago
Pardon my ignorance here, but is this anything that TRO can help with?  If so, let me know and we can get something turned around asap!
Attachment #366718 - Attachment is patch: false
Attachment #366718 - Attachment mime type: text/plain → image/png
Attachment #366718 - Flags: review?(buchanae) → review+
Neil, if you recut the learn more images, I'll commit the patch and new images in one go.

Thanks!
(Assignee)

Comment 11

10 years ago
Created attachment 368433 [details]
New Learn More images and patch

Okay, here's the new images and patch to make the Learn More text less craptacular-looking.
Attachment #368433 - Flags: review?(buchanae)
Attachment #368433 - Attachment is patch: false
Attachment #368433 - Attachment mime type: text/plain → application/zip
Attachment #368433 - Flags: review?(buchanae) → review+
(Assignee)

Comment 12

10 years ago
Created attachment 368438 [details]
Another attempt at the learn more images

Just the images this time (the last patch is still relevant). Any better?
Attachment #368433 - Attachment is obsolete: true
Attachment #368438 - Flags: review?(buchanae)

Updated

10 years ago
Whiteboard: style
Target Milestone: --- → 3.0
Comment on attachment 368438 [details]
Another attempt at the learn more images

i think i committed these in r23656.  is this resolved fixed now?
Attachment #368438 - Flags: review?(buchanae) → review+
(In reply to comment #13)
> (From update of attachment 368438 [details])
> i think i committed these in r23656.  is this resolved fixed now?

It's looking a lot better, but we're still clipping the bottom of p, q, j, g letters in IE 6, but that can be spun off.
(Assignee)

Comment 15

10 years ago
This is mostly fixed - the clipping in IE is a side effect of how these images need to be cut to work cross-browser, so it's ultimately a minor issue I don't think needs revisiting.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Fine by me -- at this point, it's something I'm totally happy to live with, too.

Verified FIXED.
Status: RESOLVED → VERIFIED
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.