480698 - Search bar dropdown menu doesn't open on click

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[u60234]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090227 Minefield/3.2a1pre
BuildID=20090227043019
SourceStamp=0e13ae11c939

Clicking the engine icon in Search bar no longer open the menu with the other search providers. Pressing Alt+Down Arrow works though.

This is a regression from the 20090227 nightly. A backout of bug 311053 confirmed that bug as the culprit.

Comment 2

[Bill Gianopoulos [:WG9s]]

Fails under Linux also.

OS -> All

Comment 3

[Bill Gianopoulos [:WG9s]]

I could not really figure out if this was really a core bug or if the Firefox search code was really doing something invalid.  I changed it to core anyway because there is currently no way to request blocking status on Firefox trunk bugs.

Comment 4

[Bill Gianopoulos [:WG9s]]

For what it's worth, backing out just the nsMenuFrame part of the patch from bug 311053 is sufficient to clear the regression.

Comment 6

[[e-mail]]

Attachment: Attribute overload, v1

Pick and choose. This version removes type="menu"...

Comment 7

[[e-mail]]

Attachment: Attribute overload, v2

...while this version removes popup="_child" and position="after_start".

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 364784 [details] [diff] [review]
Attribute overload, v1

We need the "open" attribute for styling. Apparently this depends on type="menu", although I don't know where this happens.

Comment 10

[[e-mail]]

(In reply to comment #8)
> (From update of attachment 364784 [details] [diff] [review])
> We need the "open" attribute for styling. Apparently this depends on
> type="menu", although I don't know where this happens.
nsMenuFrame.cpp

Comment 12

[[e-mail]]

Pushed changeset d292ca6cf27b to mozilla-central.

Comment 13

[Gerd]

Can't confirm that it is fixed.

Still does not work in Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2a1pre) Gecko/20090301 ID:20090301111632 (latest hourly build for Windows).

Comment 14

[Jim Jeffery not reading bug-mail 1/2/11]

Now WFM using latest hourly build: 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090301 Minefield/3.2a1pre Firefox/3.0.4 ID:20090301132600

Changeset: http://hg.mozilla.org/mozilla-central/rev/d292ca6cf27b

@Gerd  I think you were a build too soon...

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on trunk with builds on OS X and Windows:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre

Ryan, do we have already a test which covers this part?