480705 - opening "Saved Searches" in b.m.o. gives error

Status: RESOLVED DUPLICATE of bug 477513

(bugzilla.mozilla.org :: General, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

STR:
- open given url (after login)

actual:
Bugzilla has suffered an internal error. Please save this page and send it to [e-mail] with details of what you were doing at the time this message appeared.
URL: https://bugzilla.mozilla.org/userprefs.cgi?tab=saved-searches
undef error - Wide character in subroutine entry at /data/www/bugzilla.mozilla.org/Bugzilla/Token.pm line 216.

expected:
showing saves searches =)

didn't find any reports for this, so feel free to dupe away

Comment 1

[Dave Miller [:justdave]]

can't reproduce this myself... wonder if it's specific to something in one of your searches...

Comment 2

[Max Kanat-Alexander]

  You could test using a search that searches for multi-byte characters, and try a search that has multi-byte characters in the name. Neither of those *should* be a problem, but hey, there might be some unexpected bug somewhere.

  Oh, or we could be generating some sort of token that involves MD5-hashing something, and the Perl md5_hex function doesn't like utf8-tagged strings.

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to comment #2)
> You could test using a search that searches for multi-byte characters,

i failed to reproduce :-/.

> and try a search that has multi-byte characters in the name.

none of the ones in my footer does have MBC, i cannot tests the others because of the bug, but i think none of my saved searches has MBC in their name.

> Oh, or we could be generating some sort of token that involves MD5-hashing
> something, and the Perl md5_hex function doesn't like utf8-tagged strings.

how about a (bored) bugzilla admin creating a test account, copying over my saved searches and disabling/deleting them one-by-one to find the culprit :).

Comment 4

[Dmitry Cherkasov]

Works for me.

Can be reproduced like following:
1) Create some custom search with non-English letters (e.g. Russian)
2) Click newly created link

Reproduced in BUGZILLA-3_2_2, BUGZILLA-3_2-STABLE, Bugzilla_Stable. Does not occur in Bugzilla-3.2.

Can also be reproduced at this very site (bugzilla.mozilla.org) -- the difference is only in the line number in Token.pm that is referenced by the error message -- it is 184 for 3.2* and 216 for bugzilla.mozilla.org.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

i was able to reproduce now too using "ЯЖ@Цф┬ŞΨђ" for the name of the to be saved search.
but i haven't used such characters for my saved searches, my native language is german and i failed to reproduce using german umlauts (despite i didn't use umlauts for the names, it's all english only if i recall correctly).

Comment 6

[Max Kanat-Alexander]

Okay--I forget, LpSolit: did we already fix this upstream? We just need to do the same thing we did for recode.pl.

Comment 7

[Frédéric Buclin]

Yes, this is fixed upstream. Just apply the patch from bug 477513 to b.m.o.

Comment 8

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to comment #7)
> Just apply the patch from bug 477513 to b.m.o.

errm, will/could this be done as a single checkin or within a normal b.m.o. bugzilla-update (bug# anyone?)?

Comment 9

[Frédéric Buclin]

(In reply to comment #8)
> errm, will/could this be done as a single checkin or within a normal b.m.o.
> bugzilla-update (bug# anyone?)?

justdave can apply the patch without having to wait for a full upgrade. Shouldn't take him more than 2 minutes to do it. ;)

Comment 10

[Dave Miller [:justdave]]

Looks like that patch was applied to the 3.2 branch, so we'll just pick it up from upstream.  I've been doing that periodically anyway as long as nothing drastic is checked in. (upgrades within the branch are usually painless).

Comment 11

[Dave Miller [:justdave]]

We'll pick this up tonight, in a little over an hour.

Comment 12

[(mostly gone) XtC4UaLL [:xtc4uall]]

thanks Dave for fixing this in bug 482412. access to my beloved saved-searches is restored =)