The default bug view has changed. See this FAQ.

Remove XP_MAC from mozilla/security

RESOLVED FIXED in mozilla17

Status

()

Core
Security: PSM
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: Jonathan Steele, Assigned: Usul)

Tracking

unspecified
mozilla17
PowerPC
Mac System 9.x
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [psm-easy], URL)

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Notes:
1. We're talking about removing XP_MAC, not XP_MACOSX
2. XP_MAC code is code for the old pre-OSX versions of MacOS
3. The code must be removed from the right repositories.
   For NSPR and NSS, the CVS repository is still the master upstream 
   repository.
4. According to 
> http://mxr.mozilla.org/security/search?string=XP_MAC&case=on&find=mozilla%2Fsecurity%2F&findi=&filter=XP_MAC%5Cb&hitlimit=&tree=security
all the remaining occurrences of XP_MAC are in PSM, not in NSS, 
so I am reassigning this bug to PSM.
Assignee: nobody → kaie
Component: Libraries → Security: PSM
OS: Mac OS X → Mac System 9.x
Product: NSS → Core
QA Contact: libraries → psm
Hardware: x86 → PowerPC
Version: trunk → unspecified
To clarify, according to that URL in the previous comment, all the remaining 
occurrences of XP_MAC under mozilla/security are in PSM, not in NSS.
Summary: Remove XP_MAC from /security → Remove XP_MAC from mozilla/security
Blocks: 281889

Updated

7 years ago
Assignee: kaie → nobody
Whiteboard: [psm-easy]
(Assignee)

Comment 3

6 years ago
Created attachment 529942 [details] [diff] [review]
Proposed patch based on the mxr query

Removing XP_Mac , based on mxr queries.
Assignee: nobody → ludovic
Status: NEW → ASSIGNED
Attachment #529942 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #529942 - Flags: review? → review?(nelson)
(Assignee)

Updated

6 years ago
Attachment #529942 - Flags: review?(nelson) → review?(bsmith)
(Assignee)

Comment 4

6 years ago
Bryan, review ping
Created attachment 578863 [details] [diff] [review]
Remove XP_MAC from security/ [v2: v1 merged to tip]
Attachment #529942 - Attachment is obsolete: true
Attachment #578863 - Flags: superreview?(kaie)
Attachment #578863 - Flags: review+
Attachment #529942 - Flags: review?(bsmith)
Blocks: 703834

Updated

5 years ago
Attachment #578863 - Flags: superreview?(kaie) → superreview+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Pushing without Try results since this is dead code removal. Note that the code in nsNSSIOLayer.cpp was already removed elsewhere in the last 8 months.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b15957ea2fba

Ludovic, to make life easier in the future, please make sure that your hg is configured to generate all the needed metadata for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
(In reply to Ryan VanderMeulen from comment #6)
> Pushing without Try results since this is dead code removal. Note that the
> code in nsNSSIOLayer.cpp was already removed elsewhere in the last 8 months.
> 

Well, that was clearly a bad decision. This lit up the tree nicely. Try next time kthxbye. Bustage fix.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef116cb88c2a
(Assignee)

Comment 8

5 years ago
(In reply to Ryan VanderMeulen from comment #6)
> Pushing without Try results since this is dead code removal. Note that the
> code in nsNSSIOLayer.cpp was already removed elsewhere in the last 8 months.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/b15957ea2fba
> 
> Ludovic, to make life easier in the future, please make sure that your hg is
> configured to generate all the needed metadata for checkin. Thanks!
> https://developer.mozilla.org/en-US/docs/
> Creating_a_patch_that_can_be_checked_in

I would if this wasn't cvs code :-)
(Assignee)

Comment 9

5 years ago
Oups my bad.
https://hg.mozilla.org/mozilla-central/rev/b15957ea2fba
https://hg.mozilla.org/mozilla-central/rev/ef116cb88c2a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.