480786 - context menu in threadpane is inconsistent in unfocused thread

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Phil Lacy]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090228 Shredder/3.0b3pre

context menu acting on unselected thread will jump back to selected thread if a menu item with submenu is focused

Reproducible: Always

Steps to Reproduce:
1.focus on thread A
2.rt click on different thread B
3.mouse move direct to menu with submenu
4.move to other menu item

Actual Results:  
acted on thread changes from context menu thread B to selected thread A

Expected Results:  
all context menu acts on thread B

This is applicable to menu items with sub-menus. Enter/exit any non branched menu and focus remains correct.

Comment 1

[Phil Lacy]

http://mxr.mozilla.org/comm-central/source/mail/base/content/mailContextMenus.js#77
here's where selected item looses focus.

Comment 2

[Phil Lacy]

http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#504
I think this is the one. It seems to fire the onpopuphiding event when the submenu's close

Comment 3

[Phil Lacy]

Attachment: sets a target for the onpopuphiding event of main popup

Not sure why my patch has problem with the signature bytes at beginning. Someone else may have to add the changes and make a patch that is cleaner.

Comment 4

[Phil Lacy]

Attachment: bad submittal-trying again

same patch only uploaded as patch. Hopefully this will show up correctly.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 364851 [details] [diff] [review]
bad submittal-trying again

Nice catch! r=mkmelin

I'll check it in mudolo the utf-8 bom change, or whatever is showing up as the first patch hunk.

Comment 6

[Magnus Melin [:mkmelin]]

Thx for the patch!

changeset:   2113:07674dbbfbc4
http://hg.mozilla.org/comm-central/rev/07674dbbfbc4

->FIXED