480887 - mozilla-plugin.pc missing definition of XP_UNIX and OJI

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Braden]

Since some recent reorganization (possibly associated with bug 455458), it's evident that mozilla-plugin.pc needs to define the preprocessor symbols XP_UNIX and OJI.  Presumably the latter should be conditional based on the build configuration.

Comment 1

[Benjamin Smedberg]

jst/josh: I thought the NPAPI headers weren't supposed to require any external defines at all... has that changed?

Comment 2

[Josh Aas]

They do require defines for OS detection - XP_UNIX, XP_MACOSX and the like. We expect plugin authors to define those (add XP_MACOSX=1 in an Xcode project file for a plugin, for example). The fact that the XP_* defines match Mozilla's is historic, they aren't technically related to that system iirc. I believe the same system for OS defines is used in WebKit's headers. We probably want to change this some day but haven't gotten around to it.

Comment 3

[Josh Aas]

Is this file only used for unix systems? Can we just add "-DXP_UNIX" or do we have to be conditional about it?

Comment 4

[Braden]

It's only used for POSIXy systems. I don't think it needs to be conditional. Note that mozilla-js.pc already adds -DXP_UNIX unconditionally.

Comment 5

[Josh Aas]

Attachment: fix v1.0

Comment 6

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/4bb6d29863d0

Comment 7

[Josh Aas]

Comment on attachment 366739 [details] [diff] [review]
fix v1.0

We should take this on the 1.9.1 branch. Safe packaging fix.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 366739 [details] [diff] [review]
fix v1.0

a191=beltzner

Comment 9

[Josh Aas]

pushed to mozilla-1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/16cd24b194f4