Closed Bug 480887 Opened 13 years ago Closed 13 years ago

mozilla-plugin.pc missing definition of XP_UNIX and OJI

Categories

(Firefox Build System :: General, defect)

1.9.1 Branch
x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: braden, Assigned: jaas)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Since some recent reorganization (possibly associated with bug 455458), it's evident that mozilla-plugin.pc needs to define the preprocessor symbols XP_UNIX and OJI.  Presumably the latter should be conditional based on the build configuration.
Flags: wanted1.9.1?
Flags: blocking1.9.1?
jst/josh: I thought the NPAPI headers weren't supposed to require any external defines at all... has that changed?
They do require defines for OS detection - XP_UNIX, XP_MACOSX and the like. We expect plugin authors to define those (add XP_MACOSX=1 in an Xcode project file for a plugin, for example). The fact that the XP_* defines match Mozilla's is historic, they aren't technically related to that system iirc. I believe the same system for OS defines is used in WebKit's headers. We probably want to change this some day but haven't gotten around to it.
Is this file only used for unix systems? Can we just add "-DXP_UNIX" or do we have to be conditional about it?
Flags: wanted1.9.1?
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
It's only used for POSIXy systems. I don't think it needs to be conditional. Note that mozilla-js.pc already adds -DXP_UNIX unconditionally.
Assignee: nobody → joshmoz
Attached patch fix v1.0Splinter Review
Attachment #366739 - Flags: review?(benjamin)
Attachment #366739 - Flags: review?(benjamin) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/4bb6d29863d0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 366739 [details] [diff] [review]
fix v1.0

We should take this on the 1.9.1 branch. Safe packaging fix.
Attachment #366739 - Flags: approval1.9.1?
Comment on attachment 366739 [details] [diff] [review]
fix v1.0

a191=beltzner
Attachment #366739 - Flags: approval1.9.1? → approval1.9.1+
pushed to mozilla-1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/16cd24b194f4
Keywords: fixed1.9.1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.