All users were logged out of Bugzilla on October 13th, 2018

mozilla-plugin.pc missing definition of XP_UNIX and OJI

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: braden, Assigned: jaas)

Tracking

({fixed1.9.1})

1.9.1 Branch
x86
Linux
fixed1.9.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Since some recent reorganization (possibly associated with bug 455458), it's evident that mozilla-plugin.pc needs to define the preprocessor symbols XP_UNIX and OJI.  Presumably the latter should be conditional based on the build configuration.
(Reporter)

Updated

10 years ago
Flags: wanted1.9.1?
Flags: blocking1.9.1?

Comment 1

10 years ago
jst/josh: I thought the NPAPI headers weren't supposed to require any external defines at all... has that changed?
(Assignee)

Comment 2

10 years ago
They do require defines for OS detection - XP_UNIX, XP_MACOSX and the like. We expect plugin authors to define those (add XP_MACOSX=1 in an Xcode project file for a plugin, for example). The fact that the XP_* defines match Mozilla's is historic, they aren't technically related to that system iirc. I believe the same system for OS defines is used in WebKit's headers. We probably want to change this some day but haven't gotten around to it.
(Assignee)

Comment 3

10 years ago
Is this file only used for unix systems? Can we just add "-DXP_UNIX" or do we have to be conditional about it?
Flags: wanted1.9.1?
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
(Reporter)

Comment 4

10 years ago
It's only used for POSIXy systems. I don't think it needs to be conditional. Note that mozilla-js.pc already adds -DXP_UNIX unconditionally.
(Assignee)

Updated

10 years ago
Assignee: nobody → joshmoz
(Assignee)

Comment 5

10 years ago
Created attachment 366739 [details] [diff] [review]
fix v1.0
Attachment #366739 - Flags: review?(benjamin)

Updated

10 years ago
Attachment #366739 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

10 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/4bb6d29863d0
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

10 years ago
Comment on attachment 366739 [details] [diff] [review]
fix v1.0

We should take this on the 1.9.1 branch. Safe packaging fix.
Attachment #366739 - Flags: approval1.9.1?
Comment on attachment 366739 [details] [diff] [review]
fix v1.0

a191=beltzner
Attachment #366739 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 9

10 years ago
pushed to mozilla-1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/16cd24b194f4
Keywords: fixed1.9.1

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.