[fix in hand]Need a -moz-all value for user-select

VERIFIED FIXED in M18

Status

()

Core
CSS Parsing and Computation
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: Simon Fraser, Assigned: Pierre Saslawsky)

Tracking

Trunk
All
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fix in hand] [nsbeta3+])

Attachments

(4 attachments)

(Reporter)

Description

18 years ago
To allow the editor to handle pages with form elements, the user has to be able 
to select and delete form elements as objects. The CSS 3 draft describes user-
select but is unclear about how different user-select values applied to various 
elements in a hierarchy affect selection behavior. Because we need a well-defined 
behaviour now, we need to go with a -moz extension.

user-select: -moz-all should behave like user-select: none, in that applying -
moz-all at any level in the hierarchy should apply to all descendent elements.
(Reporter)

Updated

18 years ago
Keywords: nsbeta3
(Reporter)

Updated

18 years ago
Blocks: 25161
(Assignee)

Comment 1

18 years ago
Previous bugs on selection were bug 12520 and bug 42864. I'll make a new testcase 
based on those found there.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

18 years ago
I have a fix. Simon: could you review? Marc, Beth: could you approve?
Summary: Need a -moz-all value for user-select → [fix in hand]Need a -moz-all value for user-select
Whiteboard: [fix in hand]
Target Milestone: --- → M18
(Assignee)

Comment 3

18 years ago
Created attachment 12565 [details] [diff] [review]
patch file
(Assignee)

Comment 4

18 years ago
Created attachment 12566 [details] [diff] [review]
source for review
(Assignee)

Comment 5

18 years ago
Created attachment 12567 [details]
testcase
(Reporter)

Comment 6

18 years ago
Pierre: you need to sync with my nsFrame checkin to get IsSelectable signature 
changes. Other than that, the changes look good. Thanks for the prompt fix!

Comment 7

18 years ago
Approved for nsbeta3
Whiteboard: [fix in hand] → [fix in hand] [nsbeta3+]
(Assignee)

Comment 8

18 years ago
Fix checked in:
nsCSSKeywordList.h
nsCSSProps.cpp
nsFrame.cpp
nsStyleConsts.h
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 9

18 years ago
Testing with 8/25 build, verifying bug fixed. Behavior accurately reflects the 
CSS3 draft as follows:

'This property is not inherited, but it does affect children in the same way 
that display: none does, it limits it. That is if an element is user-select: 
none, it doesn't matter what the user-select value is of its children,         
the element's contents or it's childrens contents cannot be selected.'
Status: RESOLVED → VERIFIED
(Assignee)

Comment 10

18 years ago
Created attachment 14723 [details]
just in case: new testcase with "-moz-user-select" instead of "user-select"
You need to log in before you can comment on or make changes to this bug.