Closed Bug 480999 Opened 16 years ago Closed 16 years ago

Irrelevant username check in the 'Email Addresses, Bug Numbers, and Votes' section if no checkbox is checked

Categories

(Bugzilla :: Query/Bug List, defect, P4)

Product:
Bugzilla
Component:
Query/Bug List
Version:
3.3.3
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.4

People

(Reporter: vitaly.fedrushkov, Assigned: LpSolit)

References

(
URL
)

Details

Attachments

(1 file)

patch, v1
1.35 KB, patch
mkanat
: review+
Details | Diff | Splinter Review 
How to reproduce:

1. Go to advanced search
2. Clear every checkbox in 'Any of' set:
the bug assignee
the reporter
the QA contact
a CC list member
a commenter
3. Enter incorrect email into 'email1' input field and press 'Search'

Result:

The name user@example.com is not a valid username. Either you misspelled it, or the person has not registered for a Bugzilla account. 

Expected result: 

Do not check value which will not be used in a query.

Symptom described by Timur Batyrshin, see also https://bugzilla.altlinux.org/show_bug.cgi?id=19043
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Attached patch patch, v1 — — Splinter Review 
Only check the login name if at least one checkbox is checked.
Assignee: query-and-buglist → LpSolit
Status: NEW → ASSIGNED
Attachment #364978 - Flags: review?(mkanat)
Comment on attachment 364978 [details] [diff] [review]
patch, v1

r=mkanat by inspection
Attachment #364978 - Flags: review?(mkanat) → review+
I'm OK with backporting this to 3.2 if you want, or we can just check it into 3.4.
Flags: approval3.2?
Flags: approval+
Target Milestone: --- → Bugzilla 3.2
Just 3.4, otherwise I need the fix from bug 154482, and it didn't land on the 3.2 branch.
Flags: approval3.2?
Target Milestone: Bugzilla 3.2 → Bugzilla 3.4
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.173; previous revision: 1.172
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Irrelevant username check in 'Email Addresses, Bug Numbers, and Votes' box → Irrelevant username check in the 'Email Addresses, Bug Numbers, and Votes' section if no checkbox is checked
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: