Remove rogue Byte Order Mark

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Wurblzap, Assigned: Wurblzap)

Tracking

({regression})

3.3.3
Bugzilla 3.4
regression
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 364992 [details] [diff] [review]
Patch

Bug 476090 and bug 344559 accidentally introduced Byte Order Marks to two files. (The latter was fixed by bug 477662.) BOMs are known to cause trouble and should be avoided; for example, see bug 294605, comment 5, bug 413121, comment 1, and bug 328166.

This patch removes the BOM and adds a check for them to test 5.
Attachment #364992 - Flags: review?(mkanat)

Comment 1

9 years ago
Comment on attachment 364992 [details] [diff] [review]
Patch

I only see one BOM being removed in this patch?

Also, we can probably re-use an existing loop for the test so that we don't have to keep re-opening files, no?
Attachment #364992 - Flags: review?(mkanat) → review-
(Assignee)

Updated

9 years ago
Target Milestone: --- → Bugzilla 3.4
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> (From update of attachment 364992 [details] [diff] [review])
> I only see one BOM being removed in this patch?

Yeah, as said, the first one was fixed by bug 477662.

> Also, we can probably re-use an existing loop for the test so that we don't
> have to keep re-opening files, no?

In bug 295205, I wanted to have all in one loop. LpSolit insisted on having
separate loops, though, so that the testing results would be displayed in real
time. I don't mind, but please make up your minds.

Comment 3

9 years ago
Comment on attachment 364992 [details] [diff] [review]
Patch

I'd rather have one loop, but this is OK.
Attachment #364992 - Flags: review- → review+
(Assignee)

Comment 4

9 years ago
Both BOMs came in after the 3.2 branch, so I see no immediate reason for a backport.
Flags: approval?

Updated

9 years ago
Flags: approval? → approval+
(Assignee)

Comment 5

9 years ago
Checking in t/005whitespace.t;
/cvsroot/mozilla/webtools/bugzilla/t/005whitespace.t,v  <--  005whitespace.t
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Summary: Remove rogue Byte Order Marks → Remove rogue Byte Order Mark
You need to log in before you can comment on or make changes to this bug.