Closed Bug 481028 Opened 15 years ago Closed 15 years ago

abcasm: make OP_label explicit, not implicit

Categories

(Tamarin Graveyard :: Tools, defect)

Product:
Tamarin Graveyard
Component:
Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: tharwood, Assigned: tharwood)

Details

Attachments

(1 file)

Proposed patch
2.67 KB, patch
edwsmith
: review+
Details | Diff | Splinter Review
Attached patch Proposed patch — — Splinter Review 
The assembler's L1: style labels should only guide the assembler's internal calculations.  If the program needs a label, then it should be explicitly coded.

Attached patch:
- never generates an OP_label by assembler-internal calculations.
- supports label as an instruction so it can be coded into the program.
- modifies the two testcases that need a label on a backwards branch.
Attachment #364995 - Flags: review?(edwsmith)
Attachment #364995 - Flags: review?(edwsmith) → review+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: