481174 - Provide a generic default theme instead of relying on winstripe as the default

Status: NEW

(Toolkit :: Themes, defect)

Description

[Robert Strong (they/them - no direct email)]

This has been discussed a few times previously but I didn't find a bug for it so I am filing. Platforms that don't have a theme shouldn't rely on winstripe as the default theme since it makes us have to add css, etc. when changes are made to winstripe. An example of an extreme case... imagine trying to maintain pinstripe in a manner that made windows users happy.

Comment 1

[Robert Kaiser]

You mean something like a "genericstripe" or "classic" that e.g. winstripe, gnomestripe, pmstripe, maybe even pinstripe would be derived from or based upon?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Winstripe is only the default for non-Mac-non-Windows (i.e. Linux and OS/2), and only in Toolkit. Factoring out the common parts of winstripe/pmstripe/gnomestripe into yet another theme sounds like more trouble that it would be worth, especially if the only motivation is to avoid adding a fallback rule in bugs like bug 390734.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #1)
> You mean something like a "genericstripe" or "classic" that e.g. winstripe,
> gnomestripe, pmstripe, maybe even pinstripe would be derived from or based
> upon?
Yes

(In reply to comment #2)
> Winstripe is only the default for non-Mac-non-Windows (i.e. Linux and OS/2),
> and only in Toolkit. Factoring out the common parts of
> winstripe/pmstripe/gnomestripe into yet another theme sounds like more trouble
> that it would be worth, especially if the only motivation is to avoid adding a
> fallback rule in bugs like bug 390734.
This is something that was discussed a while back (perhaps it was at the summit?) and Vlad brought it up on Monday. Besides removing the fallback this separation would allow for consistency within the theme for any platforms / apps using it. It is also used for WinCE and iirc there is interest in having Firefox in full or close to it on WinCE and currently WinCE has native theming turned off. I wouldn't be surprised if there are other reasons for having a default theme as well.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Not really just WinCE -- many platforms either don't give us easy access to their native themeing or we can only access them in a slow way; it would be nice to have a theme that's rendered purely with gecko.  Starting out with winstripe and just going through and examining -moz-appearance usage would probably get us most of the way there.