481202 - Necko xpcshell tests failing when socket is still live

Status: RESOLVED WORKSFORME

(Core :: Networking, defect)

Description

[Johnathan Nightingale [:johnath]]

The xpcshell-based necko tests that use httpd.js are failing intermittently when the server socket is still in use from the previous test run.  bz and sayre suggest that we had, and fixed, this problem with reftests, but not yet with xpcshell.

Sample log from mozilla-1.9.1:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1236091816.1236095551.15580.gz&fulltext=1#err0

Comment 1

[Johnathan Nightingale [:johnath]]

Likewise from mozilla-central:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1236102704.1236106439.7952.gz

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Did you see this on any machine other than bm-xserve17 ? This is bug 478150 otherwise.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

I rebooted bm-xserve17 to clean it up, and it got another mozilla-central unit test job.

Comment 4

[Ed Morley [:emorley]]

Mass marking whiteboard:[orange] bugs WFM (to clean up TBPL bug suggestions) that:
* Haven't changed in > 6months
* Whose whiteboard contains none of the strings: {disabled,marked,random,fuzzy,todo,fails,failing,annotated,leave open,time-bomb}
* Passed a (quick) manual inspection of bug summary/whiteboard to ensure they weren't a false positive.

I've also gone through and searched for cases where the whiteboard wasn't labelled correctly after test disabling, by using attachment description & basic comment searches. However if the test for which this bug was about has in fact been disabled/annotated/..., please accept my apologies & reopen/mark the whiteboard appropriately so this doesn't get re-closed in the future (and please ping me via IRC or email so I can try to tweak the saved searches to avoid more edge cases).

Sorry for the spam! Filter on: #FFA500