481252 - Add a generic text-area "class" to ThunderHead

Status: RESOLVED EXPIRED

(Skywriter Graveyard :: Thunderhead, enhancement)

Description

[Dany Zatuchna]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009020911 Ubuntu/8.10 (intrepid) Firefox/3.0.6
Build Identifier: c98268c8f4be

A generic text-area "class" needs to be added to ThunderHead in order to replace (later on) the current editor implementation in Bespin.

Reproducible: Always

Comment 1

[Dany Zatuchna]

Attachment: The additional code to th.js

This file contains two classes:
1. th.TextArea - a generic text area
2. th.Scrollbar2 - a slightly more general version of th.Scrollbar

These classes can be added as is to th.js

Comment 2

[Dany Zatuchna]

One thing I forgot, and I did not include it so that th based stuff won't break.
On th.js, line 234 (the only place in the file where a clearRect function is used) should be commented in order to enjoy the benefits of smart redraw.

Also, on comment #1 there's a mistake, the code needs to be added to components.js and not th.js

Comment 3

[Dany Zatuchna]

Attachment: Text Area diagram

This is a diagram I cooked up which I hope explains the weird terminology I employed in my code

Comment 4

[Dany Zatuchna]

Attachment: Patch to upgrade the current TextArea to TextArea version 2

The patch contains:
1. Changes to components.js
2. A commented line in th.js (this does not seem to affect existing th based widgets, like the dashboard)
3. Files to test the the new TextArea: test.html

Comment 5

[Dany Zatuchna]

Attachment: Patch to upgrade the current TextArea to TextArea version 2.2

Text area now uses a model to store the data, and is plugged to a modified version of the Bespin actions. Modified because it has to be adjusted to the text-area.

Comment 6

[Ben Galbraith]

Dany,

Before I apply the patch, I plan to eject isRowDirty on the editor model, which is (a) duplicated and (b) seems unnecessary for your patch to function. Why is it there?

Comment 7

[Dany Zatuchna]

Attachment: Patch to upgrade the current TextArea to TextArea version 2.3

This update includes many more "action" adjustments and now features navigation (complete) and selection.

The only thing left is to adjust the undo/redo stack and a clipboard.

Comment 8

[Dany Zatuchna]

Attachment: Tidied up the TextArea code

Tidier version of the text-area widget.

I think this will help people understand the code better.

Comment 9

[Ben Galbraith]

Dany,

I went to apply the patch against the tip and it failed. I can fix the diff no problem, but I was planning on refactoring your changes and it would be easier if you did it on your end for me. Can you do this:

- create a new directory front/js/thx
- put textarea and your related test files into that directory? put both the model and the component in a file textarea.js

thx!

Comment 10

[Dany Zatuchna]

Attachment: TextArea separated from th

There you go ben

Comment 11

[Ben Galbraith]

Committed, thanks.

Comment 12

[Gordon P. Hemsley [:GPHemsley]]

From what I can tell, this is certainly confirmed. It may even be fixed already. Until someone can provide me with more information, I'm simply going to mark this as ASSIGNED to danzat.

Will there be a TH component added to Bugzilla for these types of bugs, now that TH has its own repository?

Comment 13

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: Thunderhead.

Comment 14

[Kevin Dangoor]

Thunderhead is deprecated.