481283 - User can submit questions with no content;required fields accept <space> as valid input

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P4)

Description

[krupa raj[:krupa]]

Steps to reproduce:
1.Go to https://support-stage.mozilla.org
2.Click on "Ask a question"
3.Click on "Take me to the forum"
4.Click on "Ask a new question"
5.Enter <space> in all the fields and click submit.

expected result:
1.<spaces> are not accepted as valid in  required field.
2.There is an informative user message about acceptable input

actual result:
User can submit questions with no content;required fields accept <space> as valid input

Comment 1

[Paul Craciunoiu [:paulc]]

Gotta do some trim() :)
I think we should require a minimum length for the question and also for the description. Of course since we have different languages going on, this should be reasonable over all of them.
Maybe around 20 characters for the question and 50 for the description.

Also, is there a bug on auto-completing the extensions section?

Krupa: Since you're an avid bug-reporter, when you file these, can you include a URL? Sometimes it saves time :) Thanks!

Comment 2

[krupa raj[:krupa]]

Sure,from now on I will make sure to add a URL! :)

Comment 3

[Paul Craciunoiu [:paulc]]

Y'all, I need some quick input on comment 1:
Asking a question validation of input....
1. Trim white space
2. Require minimum length for certain fields. What should that length be? See proposed above in comment 1. We should encourage/force users to be at least minimally descriptive.

Comment 4

[David Tenser [:djst]]

The number seems unimportant as long as there's something in there. If you want a limit, let's say 5. :)

Comment 5

[Paul Craciunoiu [:paulc]]

r23361 / r23362
Added some highlighted fields, etc. Everything is translatable.

Does anyone know if tiki already has form input validation built in?

Comment 6

[E. Cooper [:ecooper]]

Logged in users can't use "Ask a Question" if a required annon email and name are required each time the validation function is called.

See http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-view_forum.php?r1=23360&r2=23361&pathrev=23361&limit_changes=100#l30

Comment 7

[Paul Craciunoiu [:paulc]]

I successfully created
https://support-stage.mozilla.org/tiki-view_forum_thread.php?comments_parentId=233491&forumId=1
just now, as an anonymous user. Why are they unable to use it?

Comment 8

[E. Cooper [:ecooper]]

A logged in user.(In reply to comment #7)
> I successfully created
> https://support-stage.mozilla.org/tiki-view_forum_thread.php?comments_parentId=233491&forumId=1
> just now, as an anonymous user. Why are they unable to use it?

Uh...Logged in users? comment 6.

Logged in users aren't shown two of the required fields, so the validation check will fail. ;)

STR
1. Log in
2. Visit https://support-stage.mozilla.org/tiki-view_forum.php?locale=en-US&forumId=1
3. Use Ask a Question to create a new topic

Expected:
Topic is created

Actual
"Before you can send us your question, please enter valid information for the highlighted fields." error is displayed with nothing highlighted.

Comment 9

[Paul Craciunoiu [:paulc]]

Oops, I misread. Thanks!
r23378 / r23379

Comment 10

[krupa raj[:krupa]]

Questions with just <Spaces> are not accepted.

Verified.

Comment 11

[Paul Craciunoiu [:paulc]]

After some testing, turns out the validation function didn't work for editing the question (for some reason, the fields are named differently on editing existing vs asking a new question, no idea why...).
So now the validation accounts for that as well.
r23522 / r23523

Comment 12

[krupa raj[:krupa]]

<Spaces> are not accepted as valid question during edit.Verified.