Parse goto command line number as decimal

RESOLVED FIXED

Status

Skywriter
General
--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Ori Avtalion (salty-horse), Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Many places in the code call parseInt without specifying the radix.
In cases where the data is directly give by the user, parseInt might interpret "010" as octal instead of decimal.

The goto command is one such case. There's no reason that if a user inputs "030" as the line number it should be interpreted as 24.
(Reporter)

Comment 1

9 years ago
Created attachment 365325 [details] [diff] [review]
Suggested patch

Comment 2

9 years ago
Thanks! In changeset 9e1069b5cd09
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
This is a mass migration from Mozilla Labs :: Bespin to Bespin :: General.

This bug likely still needs to be triaged and categorized.
Component: Bespin → General
Product: Mozilla Labs → Bespin
QA Contact: bespin → general
Target Milestone: -- → ---
You need to log in before you can comment on or make changes to this bug.