481339 - Reorganize XBL files

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Mainly some housekeeping/cleanup of the XBL files. The patch creates a chrome/content/bindings folder and moves the XBL files into the folder. The bindings.xml file is split into autocomplete.xml and bookmarks.xml, as the file was getting quite large.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 - fixed references in richpref.xml

Forgot to update the binding "inherits" URIs in richpref.xml

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 3 - really has the richpref changes

this one is good

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 4 - hg is hard

really, really has the richpref.xml changes

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 365496 [details] [diff] [review]
patch 4 - hg is hard

> placeitem {
>-  -moz-binding: url("chrome://browser/content/bindings.xml#place-item");
>+  -moz-binding: url("chrome://browser/content/bindings/bookmarks.xml#place-item");
> }

This patch is missing the changes to bookmarks.xml and bindings.xml. Otherwise looks OK, but would probably be easier to review a set of hg/sed/grep commands or whatever than it would be to review the patch :)

Comment 5

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]