Closed Bug 481340 Opened 15 years ago Closed 15 years ago

navigator.js : "Warning: assignment to undeclared variable value"

Categories

(SeaMonkey :: Location Bar, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: sgautherie, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090228 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/f7f62131998d
 +http://hg.mozilla.org/comm-central/rev/7ea34ef19dc4)

{
Warning: assignment to undeclared variable value
Source File: chrome://navigator/content/navigator.js
Line: 1860
}

Missing |var| in
http://hg.mozilla.org/comm-central/rev/7f5a9e84aa8a
Flags: in-testsuite-
Attached patch fix (obsolete) — Splinter Review
Attachment #365400 - Flags: superreview?(neil)
Attachment #365400 - Flags: review?(neil)
Attachment #365400 - Flags: superreview?(neil)
Attachment #365400 - Flags: superreview+
Attachment #365400 - Flags: review?(neil)
Attachment #365400 - Flags: review+
Comment on attachment 365400 [details] [diff] [review]
fix

No need to give it a value(!) here, since it always gets one later.
Comment on attachment 365400 [details] [diff] [review]
fix

>+  var value = "";

No need for a default value.
Attachment #365400 - Flags: superreview?(neil)
Attachment #365400 - Flags: superreview+
Attachment #365400 - Flags: review?(neil)
Attachment #365400 - Flags: review+
Comment on attachment 365400 [details] [diff] [review]
fix

Sorry Neil, I shouldn't have validated that mid'air collision :-<
Attachment #365400 - Flags: superreview?(neil)
Attachment #365400 - Flags: superreview+
Attachment #365400 - Flags: review?(neil)
Attachment #365400 - Flags: review+
carrying forward r+ sr+ from Neil
Attachment #365400 - Attachment is obsolete: true
Attachment #365407 - Flags: superreview+
Attachment #365407 - Flags: review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment on attachment 365407 [details] [diff] [review]
for checkin
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/0c9fa2b7a595
Attachment #365407 - Attachment description: for checkin → for checkin [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: