Closed Bug 481345 Opened 15 years ago Closed 15 years ago

Weave should be disabled while offline or private browsing mode is active

Categories

(Cloud Services :: General, defect, P1)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iav, Assigned: Mardak)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090303 Minefield/3.2a1pre
Build Identifier: 

Weave shouldn't upload to server opened tabs data if private browsing mode is active.

Reproducible: Always

Steps to Reproduce:
1. have work and syced 2 profile, tab sync on and running
2. switch one of profiles into private browsing mode
3. press "sync now", or wait for auto sync
4. sync on another profile

Actual Results:  
on other profile you see tabs opened on other profile in private mode

Expected Results:  
no one tab or history record opened in private browsing mode should be available on other computers or after exit from private browsing mode
We could leverage bug 439588 to have a global weave "temporarily disabled" for going offline or entering private browsing. This would pause weave from doing its usual behavior and have it continue where it left off when getting out of the temporarily disabled state.
Status: UNCONFIRMED → NEW
Depends on: 439588
Ever confirmed: true
It's not bad if weave will sync not session-related work, like all down-sync, or bookmarks, or passwords, or any changes made before entering private mode.
Priority: -- → P1
Summary: Weave shouldn't up-sync tabs if private browsing mode is active → Weave should be disabled while private browsing mode is active
Target Milestone: -- → 0.3
Depends on: 482007
Summary: Weave should be disabled while private browsing mode is active → Weave should be disabled while offline or private browsing mode is active
Attached patch v1Splinter Review
Handle both offline and private browsing status and notifications.

This builds on top of bug 482007 that adds the new checkSync function that checks if syncs should run as well as schedule future syncs.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #366259 - Flags: review?(thunder)
No longer depends on: 439588
Comment on attachment 366259 [details] [diff] [review]
v1

Looks great
Attachment #366259 - Flags: review?(thunder) → review+
http://hg.mozilla.org/labs/weave/rev/b622f51dbb1b

For now things won't sync when offline/private browsing, but the resulting sync UI isn't the greatest..
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: Weave → General
Product: Mozilla Labs → Weave
QA Contact: weave → general
Blocks: 580158
Flagging in-testsuite for further investigation
Flags: in-testsuite?
Note bug 580158 changed this pretty radically.
You need to log in before you can comment on or make changes to this bug.