Closed
Bug 481345
Opened 15 years ago
Closed 15 years ago
Weave should be disabled while offline or private browsing mode is active
Categories
(Cloud Services :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
0.3
People
(Reporter: iav, Assigned: Mardak)
References
Details
Attachments
(1 file)
4.46 KB,
patch
|
hello
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090303 Minefield/3.2a1pre Build Identifier: Weave shouldn't upload to server opened tabs data if private browsing mode is active. Reproducible: Always Steps to Reproduce: 1. have work and syced 2 profile, tab sync on and running 2. switch one of profiles into private browsing mode 3. press "sync now", or wait for auto sync 4. sync on another profile Actual Results: on other profile you see tabs opened on other profile in private mode Expected Results: no one tab or history record opened in private browsing mode should be available on other computers or after exit from private browsing mode
Assignee | ||
Comment 1•15 years ago
|
||
We could leverage bug 439588 to have a global weave "temporarily disabled" for going offline or entering private browsing. This would pause weave from doing its usual behavior and have it continue where it left off when getting out of the temporarily disabled state.
Reporter | ||
Comment 2•15 years ago
|
||
It's not bad if weave will sync not session-related work, like all down-sync, or bookmarks, or passwords, or any changes made before entering private mode.
Updated•15 years ago
|
Priority: -- → P1
Summary: Weave shouldn't up-sync tabs if private browsing mode is active → Weave should be disabled while private browsing mode is active
Target Milestone: -- → 0.3
Assignee | ||
Updated•15 years ago
|
Summary: Weave should be disabled while private browsing mode is active → Weave should be disabled while offline or private browsing mode is active
Assignee | ||
Comment 3•15 years ago
|
||
Handle both offline and private browsing status and notifications. This builds on top of bug 482007 that adds the new checkSync function that checks if syncs should run as well as schedule future syncs.
Comment 4•15 years ago
|
||
Comment on attachment 366259 [details] [diff] [review] v1 Looks great
Attachment #366259 -
Flags: review?(thunder) → review+
Assignee | ||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/b622f51dbb1b For now things won't sync when offline/private browsing, but the resulting sync UI isn't the greatest..
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Component: Weave → General
Product: Mozilla Labs → Weave
Updated•15 years ago
|
QA Contact: weave → general
Comment 8•14 years ago
|
||
Note bug 580158 changed this pretty radically.
You need to log in
before you can comment on or make changes to this bug.
Description
•