481357 - rename finalRole to role

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

nsIAccessible::finalRole -> role
nsAccessible::GetRole - > GetRoleInternal

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 366096 [details] [diff] [review]
patch

>diff --git a/accessible/public/nsIAccessible.idl b/accessible/public/nsIAccessible.idl

>+   *
>+   * @note  The values might depend on platform because of variations. Widgets
>+   *        can use ARIA role attribute to force the final role.

Just a thought: you could use "override" instead of "force".

>-    role = acc.finalRole;
>+    role = acc.role;

Nice to fix this in one place eh? It tells me the mochitests are well designed.

r=me

Comment 3

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/mozilla-central/rev/977faa9e0afa

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #2)

> Just a thought: you could use "override" instead of "force".

At this point I woudn't change comments until it's necessary.

> Nice to fix this in one place eh? It tells me the mochitests are well designed.

Sure :) See today's bug 482013 fix ;)

Comment 5

[alexander :surkov (:asurkov)]

memory leak fix - http://hg.mozilla.org/mozilla-central/rev/b5c7b097c4d8

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Remove leftover 'containerRole'

Comment 7

[Marco Zehe (:MarcoZ)]

Pushed follow-up fix on Serge's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/b5339dcad9d4