rename finalRole to role

RESOLVED FIXED in mozilla1.9.2a1

Status

()

defect
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks 1 bug)

Trunk
mozilla1.9.2a1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

nsIAccessible::finalRole -> role
nsAccessible::GetRole - > GetRoleInternal
Posted patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #366096 - Flags: review?(marco.zehe)
Attachment #366096 - Flags: review?(david.bolter)
Attachment #366096 - Flags: review?(david.bolter) → review+
Comment on attachment 366096 [details] [diff] [review]
patch

>diff --git a/accessible/public/nsIAccessible.idl b/accessible/public/nsIAccessible.idl

>+   *
>+   * @note  The values might depend on platform because of variations. Widgets
>+   *        can use ARIA role attribute to force the final role.

Just a thought: you could use "override" instead of "force".

>-    role = acc.finalRole;
>+    role = acc.role;

Nice to fix this in one place eh? It tells me the mochitests are well designed.

r=me
Attachment #366096 - Flags: review?(marco.zehe)
http://hg.mozilla.org/mozilla-central/rev/977faa9e0afa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #2)

> Just a thought: you could use "override" instead of "force".

At this point I woudn't change comments until it's necessary.

> Nice to fix this in one place eh? It tells me the mochitests are well designed.

Sure :) See today's bug 482013 fix ;)
Depends on: 482055
Blocks: 90906
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Attachment #373490 - Flags: review?(david.bolter) → review+
Pushed follow-up fix on Serge's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/b5339dcad9d4
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.