481386 - Do not send emails from dev copies of AMO

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, enhancement, P4)

Description

[Fred Wenzel [:wenzel]]

Attachment: do not send emails in DEV mode

I just sent out an erroneous email to a former Mozilla intern while testing. When in development mode, I think AMO should not actually send out emails. Otherwise, testing with production data can way too easily spam users.

I'll attach a patch that should prevent this, yet allow to debug mail sending on a debug level >= 2.

Comment 1

[Wil Clouser [:clouserw]]

Comment on attachment 365412 [details] [diff] [review]
do not send emails in DEV mode

This seems like the kind of thing that will be forgotten and become frustrating for devs in the future when mail doesn't show up.  I wish we had a good way of notifying the dev.

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to comment #1)
> (From update of attachment 365412 [details] [diff] [review])
> This seems like the kind of thing that will be forgotten and become frustrating
> for devs in the future when mail doesn't show up.  I wish we had a good way of
> notifying the dev.

You have a point there. What we could do is add a constant called DEV_EMAIL and if it's set we send all emails there instead of to the original owners, and we mention the real recipients either in the first line of the email or as part of the subject (just thinking out loud)...

How does that sound?

Comment 3

[Wil Clouser [:clouserw]]

Works for me.  We could make it default to the email address for whoever is logged in.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 365412 [details] [diff] [review]
do not send emails in DEV mode

Good idea, I will write something in that direction.

Comment 5

[Fred Wenzel [:wenzel]]

clouserw just mentioned:

EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend' 

as a fix for this in Zamboni. Woot.