481412 - mobile-linux-arm-nightly builds from modified source?

Status: VERIFIED DUPLICATE of bug 480680

(Release Engineering :: General, defect)

Description

[Axel Hecht [:Pike]]

I wonder how the fennec linux arm builds end up with a + in their platform.ini source stamp. That's indicating that hg considers the mozilla-central repo modified, which is not what I expect from the build.

[Build]
BuildID=20090304020502
Milestone=1.9.2a1pre
SourceStamp=6c0ff682551d+
SourceRepository=http://hg.mozilla.org/mozilla-central

is what's currently in platform.ini.

The latest slave is moz2-linux-slave10.

Can you check what's actually triggering this?

Comment 1

[Aki Sasaki (not active)]

[cltbld@moz2-linux-slave10 mozilla-central]$ hg diff
diff -r 6c0ff682551d nsprpub/configure
--- a/nsprpub/configure Wed Mar 04 09:50:22 2009 +0000
+++ b/nsprpub/configure Wed Mar 04 09:21:02 2009 -0800
@@ -6071,7 +6071,7 @@
 s%\]%\\&%g
 s%\$%$$%g
 EOF
-DEFS=`sed -f conftest.defs confdefs.h | tr '\012' ' ' | tr '\015' ' '`
+DEFS=`sed -f conftest.defs confdefs.h | tr '\012' ' '`
 rm -f conftest.defs

Comment 2

[Aki Sasaki (not active)]

aiui, having a modified nsprpub/configure is not out of the ordinary.

Is this blocking fennec l10n, or were you just curious?

Comment 3

[Axel Hecht [:Pike]]

I'm not sure that that it's good to have a changed configure. I know that we don't have the main configure in the repo for a good reason, I'm not sure why the nsprpub one is and get's recreated anyway.

Benjamin, Ted? What's your take on this?

This is a problem for l10n builds, as I can't update my local repos to that a modified source stamp. I can hack around that by stripping the '+', but in a 'defense in depth' sense, modified local repos should probably not go undetected.

In addition, it's not only l10n builds having trouble with this, about:buildconfig is probably having a broken link to what it's built from, and other systems that depend on this information would suffer just as bad. Like, the Tinderbox pages should probably not only talk about the revision of the mobile repo, but also to the repo/revision where they got gecko from.

Comment 4

[[e-mail] (:bhearsum)]

The nsprpub one gets recreated because we import it from CVS, where it's checked in. Maybe we should just delete it from the hg repos?

Comment 5

[(not currently active) Ted Mielczarek]

See bug 480680, which has a patch.

Comment 7

[Serge Gautherie (:sgautherie)]

V.Duplicate