Closed
Bug 481509
Opened 16 years ago
Closed 16 years ago
broken instanceof checks in pageInfo.js
Categories
(SeaMonkey :: Page Info, defect)
SeaMonkey
Page Info
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b1
People
(Reporter: dao, Assigned: bugzilla)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
There's this:
!item instanceof SVGImageElement
... twice, which should be:
!(item instanceof SVGImageElement)
|
||
Comment 1•16 years ago
|
||
Yes. There are a lot of similar bugs in our pageInfo implementation. See bug 476274 for example.
Here is a patch to fix the two instanceof checks.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #367365 -
Flags: superreview?(neil)
Attachment #367365 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Attachment #367365 -
Flags: superreview?(neil)
Attachment #367365 -
Flags: superreview+
Attachment #367365 -
Flags: review?(neil)
Attachment #367365 -
Flags: review+
Keywords: checkin-needed
|
||
Comment 3•16 years ago
|
||
Comment on attachment 367365 [details] [diff] [review]
Fix the instanceof checks
[Checkin: Comment 3]
http://hg.mozilla.org/comm-central/rev/4b60f4ade2ca
Attachment #367365 -
Attachment description: Fix the instanceof checks → Fix the instanceof checks
[Checkin: Comment 3]
|
|
||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•