Closed Bug 481509 Opened 12 years ago Closed 12 years ago

broken instanceof checks in pageInfo.js

Categories

(SeaMonkey :: Page Info, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: dao, Assigned: bugzilla)

References

Details

Attachments

(1 file)

There's this:

  !item instanceof SVGImageElement

... twice, which should be:

  !(item instanceof SVGImageElement)
Yes. There are a lot of similar bugs in our pageInfo implementation. See bug 476274 for example.
Here is a patch to fix the two instanceof checks.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #367365 - Flags: superreview?(neil)
Attachment #367365 - Flags: review?(neil)
Attachment #367365 - Flags: superreview?(neil)
Attachment #367365 - Flags: superreview+
Attachment #367365 - Flags: review?(neil)
Attachment #367365 - Flags: review+
Keywords: checkin-needed
Comment on attachment 367365 [details] [diff] [review]
Fix the instanceof checks
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/4b60f4ade2ca
Attachment #367365 - Attachment description: Fix the instanceof checks → Fix the instanceof checks [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.