Closed Bug 481515 Opened 15 years ago Closed 15 years ago

Draw a nicer tab preview

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec1.0b1+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fennec 1.0b1+ ---

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

Details

Attachments

(1 file, 1 obsolete file)

Life is always more complicated
1.73 KB, patch
pavlov
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) — — Splinter Review 
I hardcoded the proportions that the big canvas uses, don't see a better way of doing this.
Attachment #365551 - Flags: review?(pavlov)
bug 480761 makes updateTab() draw a black preview. In general, incremental drawing of the main canvas screws up drawImaging the tab when viewing area is obstructed by locationbar or the viewport is wider than the window.

I think post-beta we should handover tab preview drawImaging to CanvasBrowser so it paint just the viewing area.
Assignee: nobody → tglek
Attachment #365551 - Attachment is obsolete: true
Attachment #365551 - Flags: review?(pavlov)
tracking-fennec: --- → 1.0b1+
Attachment #365560 - Flags: review+
http://hg.mozilla.org/mobile-browser/rev/8bdd932d86ae
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Good gravy, this is a mess
(In reply to comment #3)
> Good gravy, this is a mess

It is, the late resize event really bit me here. Don't worry I'll make it all pretty and nice in bug 481527.
Can you please provide some steps to reproduce or please explain what do you understand by nicer tab preview? The way it looks now ?

Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110523 Firefox/6.0a1 Fennec/6.0a1
This code is not even in the product any more, check-in is good enough.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: