481578 - Running a test fills error console with warnings (undefined property subject.documentLoaded)

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090304 Shiretoko/3.1b3pre ID:20090304022008 and r414

Running any test fills the error console with hundreds(?) of warnings:

Warning: reference to undefined property subject.documentLoaded
Source File: file:///Volumes/data/mozilla/qa/mozmill/trunk/mozmill/extension/resource/modules/controller.js
Line: 89


function waitForEval (expression, timeout, interval, subject) {
  if (interval == undefined) {
    interval = 100;
  }
  if (timeout == undefined) {
    timeout = 30000;
  }
  
  var self = {};
  self.counter = 0;
  self.result = eval(expression);
  
  function wait(){
=>  self.result = eval(expression);
    self.counter += interval;
  }

Comment 1

[Mikeal Rogers [:mikeal] (mrogers@)]

Changes a check for == true to != undefined. If this doesn't fix it then there is no way that we can fix it.

Committed revision 415.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yeah. Warning is gone.