add libpath to link jemalloc in xulrunner and xulrunner-stub on windows ce

RESOLVED FIXED in mozilla1.9.2a1

Status

defect
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
ARM
Windows CE
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(fennec1.0a1-wm+)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Posted patch patch v.1 (obsolete) — Splinter Review
No description provided.
Attachment #365606 - Flags: review?(benjamin)
Comment on attachment 365606 [details] [diff] [review]
patch v.1

>+ifneq (,$(JEMALLOC_LIBS))
>+LDFLAGS += -LIBPATH:$(DIST)/lib -NODEFAULTLIB:coredll
>+endif

Um, shouldn't this be ifdef'd off just for Windows?
Posted patch patch v.2 (obsolete) — Splinter Review
(In reply to comment #1)
> (From update of attachment 365606 [details] [diff] [review])
> >+ifneq (,$(JEMALLOC_LIBS))
> >+LDFLAGS += -LIBPATH:$(DIST)/lib -NODEFAULTLIB:coredll
> >+endif
> 
> Um, shouldn't this be ifdef'd off just for Windows?

yea, probably should
Assignee: nobody → bugmail
Attachment #365606 - Attachment is obsolete: true
Attachment #365610 - Flags: review?(benjamin)
Attachment #365606 - Flags: review?(benjamin)
OS: Windows XP → Windows CE
Hardware: x86 → ARM
Comment on attachment 365610 [details] [diff] [review]
patch v.2

Don't scatter this around the tree; put it in JEMALLOC_LIBS itself, which is defined here:

http://mxr.mozilla.org/mozilla-central/source/config/config.mk#160

It's probably sufficient to use EXPAND_LIBNAME_PATH instead of EXPAND_LIBNAME
Attachment #365610 - Flags: review?(benjamin) → review-
tracking-fennec: --- → 1.0a1-wm+
Status: NEW → ASSIGNED
Attachment #368878 - Flags: review?(benjamin)
Attachment #365610 - Attachment is obsolete: true
Attachment #368878 - Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #368878 - Flags: approval1.9.1?
Attachment #368878 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 368878 [details] [diff] [review]
uses EXPAND_LIBNAME_PATH

a191=beltzner
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Attachment #426851 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 426851 [details] [diff] [review]
(Cv1) Copy it to comm-central
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/ccfb59da8aad


Looking for "approval-thunderbird3.0.3=?" actually.
Attachment #426851 - Attachment description: (Cv1) Copy it to comm-central → (Cv1) Copy it to comm-central [Checkin: Comment 9]
Attachment #426851 - Flags: review?(bugzilla)
Comment on attachment 426851 [details] [diff] [review]
(Cv1) Copy it to comm-central
[Checkin: Comment 9]

Approval for c-1.9.1 denied - I want to be able to track every bug that goes into the security releases and with this patch on this bug I can't do that. Please put this on a MailNews bug (which would have been more appropraite in the first place) and request approval there.
Attachment #426851 - Flags: review?(bugzilla)
(In reply to comment #10)

Moved to bug 496236.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.