481584 - add libpath to link jemalloc in xulrunner and xulrunner-stub on windows ce

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.1

Comment 1

[Reed Loden [:reed]]

Comment on attachment 365606 [details] [diff] [review]
patch v.1

>+ifneq (,$(JEMALLOC_LIBS))
>+LDFLAGS += -LIBPATH:$(DIST)/lib -NODEFAULTLIB:coredll
>+endif

Um, shouldn't this be ifdef'd off just for Windows?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2

(In reply to comment #1)
> (From update of attachment 365606 [details] [diff] [review])
> >+ifneq (,$(JEMALLOC_LIBS))
> >+LDFLAGS += -LIBPATH:$(DIST)/lib -NODEFAULTLIB:coredll
> >+endif
> 
> Um, shouldn't this be ifdef'd off just for Windows?

yea, probably should

Comment 3

[Benjamin Smedberg]

Comment on attachment 365610 [details] [diff] [review]
patch v.2

Don't scatter this around the tree; put it in JEMALLOC_LIBS itself, which is defined here:

http://mxr.mozilla.org/mozilla-central/source/config/config.mk#160

It's probably sufficient to use EXPAND_LIBNAME_PATH instead of EXPAND_LIBNAME

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: uses EXPAND_LIBNAME_PATH

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/72969ace6b09

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 368878 [details] [diff] [review]
uses EXPAND_LIBNAME_PATH

a191=beltzner

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/45679b6e9cff

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Copy it to comm-central [Checkin: Comment 9]

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 426851 [details] [diff] [review]
(Cv1) Copy it to comm-central
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/ccfb59da8aad


Looking for "approval-thunderbird3.0.3=?" actually.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 426851 [details] [diff] [review]
(Cv1) Copy it to comm-central
[Checkin: Comment 9]

Approval for c-1.9.1 denied - I want to be able to track every bug that goes into the security releases and with this patch on this bug I can't do that. Please put this on a MailNews bug (which would have been more appropraite in the first place) and request approval there.

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)

Moved to bug 496236.