protoLayout should set to NULL in moz_gtk_shutdown() [Crash @g_type_check_instance_cast @setup_widget_prototype @ensure_menu_popup_widget]

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Tracking

({crash, fixed1.9.1})

Trunk
All
Linux
crash, fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
We have
gtk_container_add(GTK_CONTAINER(gProtoWindow), protoLayout);

So, if gProtoWindow is destroyed and recreated, we should recreate protoLayout.

I think we'd better use gProtoLayout.

I found this crash because I have set "general.config.filename" in all.js, but I missed the file in firefox directory.
Firefox is shutting down while another thread is still running. (maybe another bug.)
(Assignee)

Comment 1

10 years ago
Created attachment 365638 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Attachment #365638 - Flags: review?(roc)
(Assignee)

Comment 2

10 years ago
http://hg.mozilla.org/mozilla-central/rev/89d78f1d6ecf
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Attachment #365638 - Flags: approval1.9.1?
Comment on attachment 365638 [details] [diff] [review]
patch

a191=beltzner
Attachment #365638 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 4

10 years ago
Pushed 1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5436e0de163f
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.