481673 - JS_Assert is C++-name-mangled in non-DEBUG builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

The extern "C" declaration in jsutil.h is DEBUG-only, but the function is (intentionally) always defined regardless of DEBUG.

As a result, applications built DEBUG will not link against a non-DEBUG SpiderMonkey.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Jason Orendorff [:jorendorff]]

Wes points out that one problem DEBUG applications will have calling a non-DEBUG SM is that JSTracer's size depends on #ifdef DEBUG.  We could just remove that #ifdef and JSTracer would sometimes have a few useless fields; it should not hurt performance.

Or maybe refusing to link in this case is a feature, not a bug.  But I'm not quite prepared to admit that yet.  Brendan?

Comment 3

[Brendan Eich [:brendan]]

This bug's an easy fix.

The JSTracer struct size varying with DEBUG is a bug, should have caught that years ago when it went in. Igor, you agree?

/be

Comment 4

[Brendan Eich [:brendan]]

Wes may not run into this, but IIRC on Windows, at least with the standard debug and release CRTs, you can't mix DEBUG and NDEBUG code compiled and packaged into libraries safely. Benjamin knows all.

/be

Comment 5

[Benjamin Smedberg]

You can, as long as you don't mismatch allocators or pass FILE* across the boundaries. I think JS should be safe in that regard.

Comment 6

[Brendan Eich [:brendan]]

Mismatched allocators is all too easy, since SpiderMonkey was designed for one true malloc and allows JS_malloc | free and malloc | JS_free.

/be

Comment 7

[Mads Bondo Dydensborg]

FWIW: I was hit by this problem and discussed it with Wes and to some extent Jorendorff on IRC.

The patch by Jorendorff solves our problems; compiles and passes all our tests.

Thanks a bunch.

Comment 8

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/87a4c653c637

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/87a4c653c637

Comment 10

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c64179d6d1e2