Closed Bug 481739 Opened 13 years ago Closed 13 years ago
_splash .png eats startup time
173.11 KB, image/png
43.01 KB, application/zip
48.44 KB, image/gif
44.86 KB, image/gif
133.36 KB, patch
|Details | Diff | Splinter Review|
tried converting that file to a gif, saved at least half a second.
pngcrush does not help much, still about 50times slower than gif according to my measurements
I wonder what we could do in the PNG decoder to make things faster. We favor PNG for all our UI images. But yeah, we could certainly change that one.
I've rebuilt the page, using a new, smaller background + PNG. PNG 8-bit saved smaller than GIF in PS. We've gone from 264Kb of images to 48kb.
revised Splash GIF. Simply update index.html to reflect extension change.
This patch: * adds the new firstrun_splash.gif and firstrun_background.gif files * removes the DTD * moves CSS into the firstrun.xhtml file * removes the CSS file * changes the <title> to "Fennec" * makes the changes to both hildon and wince themes
Assignee: nobody → mark.finkle
Attachment #365921 - Flags: review?(gavin.sharp)
I forgot to remove the DTD from the locale jar.mn
you also need to rename xhtml -> html to avoid loading xhtml dtd
renames the firstrun.xhtml to firstrun.html
I'm sorry, the xhtml dtd is still being loaded, damned if I know why. I remember trying to debug this before and giving up. I think that dtd is in a jar, so it should be fast to load. I sliced off a pixel from width on _splash.gif and the black line rounding bug went away for default res(heh!). The font css is redundant, I don't see any diff when I remove the rest of css too.
also, I don't think the absolute filenames are needed.
this patch adds Taras' new image (hides rounding problem) and corrects aboutFirstrun.js This is the one for b1!
Attachment #365954 - Flags: review?(gavin.sharp) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Fennec A3
Any idea how this is supposed to be be localized now?
(In reply to comment #15) > Any idea how this is supposed to be be localized now? The new image has the same text as the old image. "Welcome to Fennec" (the "Welcome to" is white) So we are no worse off than before. However, we do need a plan for localizing it. We could always drop the "Welcome to" part as well.
can the text be made part of the html page?
We shouldn't make html part of l10n, but we could post-process something with a foo.inc file.
(In reply to comment #18) > We shouldn't make html part of l10n, but we could post-process something with a > foo.inc file. Agreed. I was going to suggest that, but was afraid you would yell at me :)
You need to log in before you can comment on or make changes to this bug.