The default bug view has changed. See this FAQ.

windows/orphans parsing code should reject nonpositive values

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
CSS Parsing and Computation
P4
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
The CSS WG just accepted the proposal in http://lists.w3.org/Archives/Public/www-style/2009Jan/0234.html per http://wiki.csswg.org/spec/css2.1#issue-105 .  We should update our parsing code to match.
(Assignee)

Comment 1

8 years ago
Created attachment 365843 [details] [diff] [review]
patch 1: rename ParsePositiveVariant, since that's not what it does
Attachment #365843 - Flags: superreview?(bzbarsky)
Attachment #365843 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

8 years ago
Created attachment 365844 [details] [diff] [review]
patch 2: fix

I have the new function a weird name since I didn't want to reuse ParsePositiveVariant with a different meaning from what it used to have.
Attachment #365844 - Flags: superreview?(bzbarsky)
Attachment #365844 - Flags: review?(bzbarsky)
Attachment #365843 - Flags: superreview?(bzbarsky)
Attachment #365843 - Flags: superreview+
Attachment #365843 - Flags: review?(bzbarsky)
Attachment #365843 - Flags: review+
Attachment #365844 - Flags: superreview?(bzbarsky)
Attachment #365844 - Flags: superreview+
Attachment #365844 - Flags: review?(bzbarsky)
Attachment #365844 - Flags: review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/c6d6c0e243b0
http://hg.mozilla.org/mozilla-central/rev/2f3c15f5b0c8
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.