Last Comment Bug 481826 - windows/orphans parsing code should reject nonpositive values
: windows/orphans parsing code should reject nonpositive values
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P4 normal (vote)
: mozilla1.9.2a1
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks: 137367
  Show dependency treegraph
 
Reported: 2009-03-06 00:14 PST by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2009-03-09 16:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 1: rename ParsePositiveVariant, since that's not what it does (20.86 KB, patch)
2009-03-06 00:21 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
bzbarsky: superreview+
Details | Diff | Review
patch 2: fix (7.76 KB, patch)
2009-03-06 00:22 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
bzbarsky: superreview+
Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2009-03-06 00:14:28 PST
The CSS WG just accepted the proposal in http://lists.w3.org/Archives/Public/www-style/2009Jan/0234.html per http://wiki.csswg.org/spec/css2.1#issue-105 .  We should update our parsing code to match.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2009-03-06 00:21:57 PST
Created attachment 365843 [details] [diff] [review]
patch 1: rename ParsePositiveVariant, since that's not what it does
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2009-03-06 00:22:54 PST
Created attachment 365844 [details] [diff] [review]
patch 2: fix

I have the new function a weird name since I didn't want to reuse ParsePositiveVariant with a different meaning from what it used to have.
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2009-03-09 16:19:19 PDT
http://hg.mozilla.org/mozilla-central/rev/c6d6c0e243b0
http://hg.mozilla.org/mozilla-central/rev/2f3c15f5b0c8

Note You need to log in before you can comment on or make changes to this bug.