Closed
Bug 481847
Opened 15 years ago
Closed 15 years ago
tabbrowser-tab focus ring is ugly
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy] [polish-visual][polish-p1])
Attachments
(1 file)
1.00 KB,
patch
|
mstange
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Although I'm not a Mac user, the focus ring for tabbrowser-tabs really doesn't look right to me. Not sure that what I propose here is correct, but I suppose it's an improvement.
Attachment #365873 -
Flags: review?(mstange)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [polish-easy] [polish-visual]
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → dao
Status: NEW → ASSIGNED
Updated•15 years ago
|
Attachment #365873 -
Flags: review?(mstange) → review+
Comment 1•15 years ago
|
||
Comment on attachment 365873 [details] [diff] [review] patch That's a lot better for sure, thanks!
Assignee | ||
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/38d5bc58cf46
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Depends on: 476738
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Assignee | ||
Updated•15 years ago
|
Attachment #365873 -
Flags: approval1.9.1?
Updated•15 years ago
|
Attachment #365873 -
Flags: approval1.9.1? → approval1.9.1+
Comment 3•15 years ago
|
||
Comment on attachment 365873 [details] [diff] [review] patch a191=beltzner
Assignee | ||
Updated•15 years ago
|
Whiteboard: [polish-easy] [polish-visual] → [waiting for bug 476738 to land on 191] [polish-easy] [polish-visual]
Assignee | ||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9726056fbac8
Keywords: fixed1.9.1
Whiteboard: [waiting for bug 476738 to land on 191] [polish-easy] [polish-visual] → [polish-easy] [polish-visual]
Comment 5•15 years ago
|
||
Verified fixed with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090408 Minefield/3.6a1pre ID:20090408030741 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090409 Shiretoko/3.5b4pre ID:20090409031809
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Comment 6•15 years ago
|
||
This bug's priority relative to the set of other polish bugs is: P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•