The default bug view has changed. See this FAQ.

Get rid of RTL search icons by using mirror transformations

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Toolkit
Themes
VERIFIED FIXED
8 years ago
4 years ago

People

(Reporter: mstange, Assigned: Ehsan)

Tracking

({rtl})

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
This idea came up in bug 462977 comment 6 and I'd like to try it out.
Keywords: rtl
(Assignee)

Comment 1

8 years ago
Created attachment 366185 [details] [diff] [review]
Patch (v1)

The Mac theme didn't originally flip the search button, so I didn't touch it.  Is there a specific reason for this behavior, though?
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #366185 - Flags: review?(dao)
(Assignee)

Comment 2

8 years ago
Markus: I'm not sure if this bug has been filed about the search bar or everywhere this image is used, so I'm assuming the former.  Please correct me if I'm wrong.
Is there a reason not to do this for all occurrences of Search-glass-rtl.png?
We should also remove Search-glass.png from browser/themes/ and use the toolkit image everywhere.
Morphing... I know Markus had more in mind than the search glass, but I think bug 482105 will be more useful with regard to the RTL layout of the search bar on OS X.
Component: Theme → Themes
No longer depends on: 481382
OS: Mac OS X → All
Product: Firefox → Toolkit
QA Contact: theme → themes
Hardware: x86 → All
Summary: Get rid of RTL searchbar images by using mirror transformations → Get rid of RTL search icons by using mirror transformations
Version: 3.1 Branch → unspecified
(Assignee)

Comment 6

8 years ago
(In reply to comment #4)
> We should also remove Search-glass.png from browser/themes/ and use the toolkit
> image everywhere.

What was the original reason that that icon went into browser/themes/?  Would removing it fall into the scope of this bug?
(Assignee)

Updated

8 years ago
Version: unspecified → Trunk
It was needed in browser but not in toolkit, so it was in browser first. When toolkit needed it, it has been copied, since toolkit can't depend on browser.
(In reply to comment #6)
> Would removing it fall into the scope of this bug?

You need to touch the surrounding code anyway, and it's trivial, so I'd say it's not out of scope. But feel free not to do it here.
(Assignee)

Comment 9

8 years ago
Created attachment 366195 [details] [diff] [review]
Patch (v2)

Remove browser versions of the search-glass icon, and also toolkit RTL versions, and use -moz-transform to flip the icon for RTL.
Attachment #366185 - Attachment is obsolete: true
Attachment #366195 - Flags: review?(mano)
Attachment #366185 - Flags: review?(dao)
Comment on attachment 366195 [details] [diff] [review]
Patch (v2)

r=mano
Attachment #366195 - Flags: review?(mano) → review+
(Assignee)

Comment 11

8 years ago
http://hg.mozilla.org/mozilla-central/rev/8277119139f6

We need a Litmus test to verify that the icons have been properly flipped.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; fa; rv:1.9.2a1pre) Gecko/20090405 Minefield/3.6a1pre ID:20090405044922

Markus, do we already have a bug for OS X?
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Comment 13

8 years ago
(In reply to comment #12)
> Markus, do we already have a bug for OS X?

Bug 482105; see comment 5.
(Assignee)

Updated

4 years ago
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.