This idea came up in bug 462977 comment 6 and I'd like to try it out.
Created attachment 366185 [details] [diff] [review] Patch (v1) The Mac theme didn't originally flip the search button, so I didn't touch it. Is there a specific reason for this behavior, though?
Markus: I'm not sure if this bug has been filed about the search bar or everywhere this image is used, so I'm assuming the former. Please correct me if I'm wrong.
Is there a reason not to do this for all occurrences of Search-glass-rtl.png?
We should also remove Search-glass.png from browser/themes/ and use the toolkit image everywhere.
Morphing... I know Markus had more in mind than the search glass, but I think bug 482105 will be more useful with regard to the RTL layout of the search bar on OS X.
(In reply to comment #4) > We should also remove Search-glass.png from browser/themes/ and use the toolkit > image everywhere. What was the original reason that that icon went into browser/themes/? Would removing it fall into the scope of this bug?
8 years ago
It was needed in browser but not in toolkit, so it was in browser first. When toolkit needed it, it has been copied, since toolkit can't depend on browser.
(In reply to comment #6) > Would removing it fall into the scope of this bug? You need to touch the surrounding code anyway, and it's trivial, so I'd say it's not out of scope. But feel free not to do it here.
Created attachment 366195 [details] [diff] [review] Patch (v2) Remove browser versions of the search-glass icon, and also toolkit RTL versions, and use -moz-transform to flip the icon for RTL.
Comment on attachment 366195 [details] [diff] [review] Patch (v2) r=mano
http://hg.mozilla.org/mozilla-central/rev/8277119139f6 We need a Litmus test to verify that the icons have been properly flipped.
Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; fa; rv:1.9.2a1pre) Gecko/20090405 Minefield/3.6a1pre ID:20090405044922 Markus, do we already have a bug for OS X?
4 years ago