481936 - Need to add beta versions to JavaScript build arrays

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: add jsbeta keys

Bug 481036 wants to add a locale-detecting button to the beta download page.  To do that we've got to put the betas in the JS array (which was temporary code to begin with...)

To use the patch just change writeDownloadItems("fx") to writeDownloadItems("fxbeta") on the page.

Comment 1

[Reed Loden [:reed]]

Comment on attachment 365984 [details] [diff] [review]
add jsbeta keys

>                 $_newest_thunderbird = $_thunderbirdDetails->getNewestVersionForLocale($locale);
>-                $_oldest_thunderbird = $_thunderbirdDetails->getOldestVersionForLocale($locale);
>+                $_beta_thunderbird = $_thunderbirdDetails->getOldestVersionForLocale($locale);
>+                $_oldest_thunderbird = $_thunderbirdDetails->getDevelVersionForLocale($locale);

These are backwards and in wrong order. Should be:
$_oldest_thunderbird = $_thunderbirdDetails->getOldestVersionForLocale($locale);
$_beta_thunderbird = $_thunderbirdDetails->getDevelVersionForLocale($locale);

getDevelVersionForLocaleFromBuildArray(), getNewestVersionForLocaleFromBuildArray(), and getOldestVersionForLocaleFromBuildArray() in productDetails.class.php seems a bit too Firefox-centric. If you're serious about supporting Thunderbird with this, this code will need fixing. If not, then I guess it's ok for now.

Comment 2

[Wil Clouser [:clouserw]]

I can switch that.

Honestly, I'd like to see all Thunderbird stuff go somewhere else and be supported by the Messaging team.  That may be pie in the sky though.

Comment 3

[Reed Loden [:reed]]

Comment on attachment 365984 [details] [diff] [review]
add jsbeta keys

Ok, r=me as long as you fix it.

Comment 4

[Wil Clouser [:clouserw]]

thanks, r22974