481946 - Vague error message on empty Switch input on log in page

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Paul Craciunoiu [:paulc]]

Steps:
1. While logged in to support.mozilla.com go to https://support-stage.mozilla.org/tiki-login_scr.php
2. Press "Switch" without entering any username.

Actual results:
Error -- An unexpected error has occurred!

Expected results:
A more specific error message such as "Please make sure to enter a username. Use the browser's Back button and try again"

Comment 1

[Paul Craciunoiu [:paulc]]

Chris, is my text suggestion okay?

Comment 2

[Chris Ilias [:cilias]]

The Switch feature is only available to admins. The text is fine. I would rather we just get rid the Switch feature from the login page.

Comment 3

[Paul Craciunoiu [:paulc]]

It's nice for testing multiple accounts though, I think.

Comment 4

[E. Cooper [:ecooper]]

I believe that error is thrown from tiki-setup_base.php when it does type checking (sometime after ~300).

Comment 5

[David Tenser [:djst]]

Paul, make sure the ending period is inside the string, since it's not being used in Japanese (see bug 433319).

Stephen, can we get some English perfection skills? :)

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

"Please be sure to enter a username before clicking 'Switch'; below, click 'Go back' to retry." -- how's that sound?

(Don't know about that whole "English perfection skills thing, TBH :-P)

Comment 7

[Paul Craciunoiu [:paulc]]

David: will do.
Stephen: I think that sounds good!

Comment 8

[David Tenser [:djst]]

I think it sounds a little too formal with that semi-colon. I know that it's most probably 100% correct but just looks a bit too much to me. :) Can we simplify a little? How about this (Stephen, feel free to object since Swedish is my main language):

Please make sure you enter a username before clicking "Switch". Click "Go back" to try again.

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: Patch for switching username

Unfortunately the fix seems to involve the function varcheck(&$array, $category) defined in tiki-setup_base.php on line 313.

I attached the patch that would work, but the setup throws the error before I can do anything in tiki-login. Fixing varcheck seems like something unnecessary. I say we just WONTFIX this...

Comment 10

[Chris Ilias [:cilias]]

WONTFIX per comment 9. Thanks Paul.

Comment 11

[Paul Craciunoiu [:paulc]]

r23860 / r23861
Got the idea while fixing bug 480428 :)

Comment 12

[Paul Craciunoiu [:paulc]]

Ooops, make that r23861 / r23862

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

I now get "Error

Username field cannot be empty. Please go back and try again." when I click the "Switch" button without specifying a username.

Verified FIXED on https://support-stage.mozilla.org/tiki-login.php