481959 - Add Select All shortcut to Cookie Manager tree

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, enhancement)

Description

[Jens Hatlak (:InvisibleSmiley)]

The Cookie Manager tree should have a Select All shortcut (Ctrl+A), especially to ease deleting all cookies displayed in filtered mode (introduced in bug 476175, together with a confirmation for deleting multiple cookies when clicking Remove Cookie or pressing Delete).

The actual implementation needs to go to HandleCookieKeyPress() in cookieViewer.js: calling cookiesTreeView.selection.selectAll(); is enough. The only (small) challenge here is to make this localizable.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Use generic selectAll shortcut

I found that we already have a generic, localized selectAll shortcut and verified that it works in this context. I also checked that the added <key> doesn't change the behavior of Ctrl+A in either the new Search field (Stored Cookies tab) or the text field (Cookie Sites tab) and that the tree on the Cookie Sites tab is unaffected by the change.

Comment 2

[[e-mail]]

Comment on attachment 367126 [details] [diff] [review]
Use generic selectAll shortcut

This doesn't even work. Not only does pressing, say, Tab, select all, pressing Ctrl+A when some other element has focus also selects all.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: approach that actually works [Checkin: Comment 5]

(In reply to comment #2)
> (From update of attachment 367126 [details] [diff] [review])
> This doesn't even work. Not only does pressing, say, Tab, select all, pressing
> Ctrl+A when some other element has focus also selects all.

You're right, I obviously did a bad job checking all that.

My new approach defines an own key entity and uses code borrowed from pageInfo.js to only apply the command to trees (i.e. it also works in the tree of the Cookie Sites tab).

Comment 4

[[e-mail]]

Comment on attachment 367281 [details] [diff] [review]
approach that actually works
[Checkin: Comment 5]

I guess copying page info is a valid way to solve the problem (I had a more fiendish way in mind, but you're not expected to be able to guess that.)

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 367281 [details] [diff] [review]
approach that actually works
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/ddadc8fdec00