Closed Bug 482028 Opened 16 years ago Closed 6 years ago

narcissus fails js tests due to lack of support for version() or options()

Categories

(Other Applications Graveyard :: Narcissus, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bc, Unassigned)

References

Details

Attachments

(1 file)

version() and options() support is required to run the js tests. narcissus does not define them however.
Flags: in-testsuite+
We could mock them up, but since Narcissus doesn't support all of the options (e.g. E4X) that SpiderMonkey does, I have a feeling that adding these will simply move where the tests fail.
Yeah, mock-up. We don't aim to run more than the ecma_* tests on Narcissus. /be
Ok. I can mock them up in js/tests/shell.js if that is ok.
Why not just mock them up in js.js?
Er, I meant jsexec.js.
bc looks up from js/tests and realizes that there is an entire world out there...
Attachment #374778 - Flags: review?(mrbkap)
Comment on attachment 374778 [details] [diff] [review] patch to add options to primitives, and to remove "version: null" >diff -r ea128fc02710 js/narcissus/jsexec.js >+ // version: null -- CF - had problems with shell.js in js/tests >+ options: options Won't this lie? In particular, if you run a narcissus shell with the JIT on in SpiderMonkey, I think you'll get spurious errors. I'm not sure what the testsuite expects, but I was sort of expecting a no-op function since Narcissus doesn't support any of SpiderMonkey's options. If you change that, can you add a version function that always returns 150? Or do things still break? > case RETURN: >+ /* CF: Was > x.result = getValue(execute(n.value, x)); >+ */ >+ x.result = n.value.type==undefined ? >+ undefined : >+ getValue(execute(n.value, x)); Since this is all in version control, we don't need to record in the source what the changes you make are. However, it would be good to add a comment about why you're doing this. I suppose this is the only place in the interpreter where it's possible to enter with an undefined (really non-existant) value? Also, please follow existing conventions in the file, I think this should be formatted as: x.result = (n.value.type == undefined) ? undefined : getValue(execute(n.value, x));
Attachment #374778 - Flags: review?(mrbkap) → review-
Blocks: 584206
Assignee: general → nobody
Component: JavaScript Engine → Narcissus
Flags: in-testsuite+
Product: Core → Other Applications
QA Contact: general → narcissus
Keywords: narcissus
Closing as Narcissus isn't maintained anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: