Closed Bug 482055 Opened 12 years ago Closed 12 years ago

use 'role' if there is no 'finalRole' in accessible object

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patchSplinter Review
Shawn, do I need sr for this?
Attachment #366122 - Flags: review?(sdwilsh)
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Comment on attachment 366122 [details] [diff] [review]
patch

r=sdwilsh

I'm having Neil look at this because he always seems to catch little things that I miss.
Attachment #366122 - Flags: superreview?(neil)
Attachment #366122 - Flags: review?(sdwilsh)
Attachment #366122 - Flags: review+
Blocks: 477844
Attachment #366122 - Flags: superreview?(neil) → superreview+
Comment on attachment 366122 [details] [diff] [review]
patch

Even I can't find something wrong with a patch this simple ;-) well, I guess the ()s before the ? are probably unnecessary.
checked in with Neil's nit, http://hg.mozilla.org/dom-inspector/rev/c5138e1ef96d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attached patch patch (obsolete) — Splinter Review
fixing mistake of previous patch
Attachment #368738 - Flags: superreview?(neil)
Attachment #368738 - Flags: review?(sdwilsh)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #368738 - Attachment is patch: true
Attachment #368738 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 368738 [details] [diff] [review]
patch

accessibleRelations.js is wrong too.
Attachment #368738 - Flags: superreview?(neil) → superreview-
Attached patch patch2Splinter Review
Attachment #368738 - Attachment is obsolete: true
Attachment #368745 - Flags: superreview?(neil)
Attachment #368745 - Flags: review?(sdwilsh)
Attachment #368738 - Flags: review?(sdwilsh)
Attachment #368745 - Flags: superreview?(neil) → superreview+
Comment on attachment 368745 [details] [diff] [review]
patch2

r=sdwilsh
Attachment #368745 - Flags: review?(sdwilsh) → review+
checked in, http://hg.mozilla.org/dom-inspector/rev/858f86b85a8b
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.