482061 - Problem setting password when setting up weave for first time on Fennec

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P1)

Description

[Jono Xia]

After you enter your username/password/passphrase for the first time and try to connect, login fails because authorization is denied (i.e. you get 401s on server resources).  If you then go back to the setup screen, the password and passphrase are blank, indicating that they were never set properly (which would explain why auth failed.)

Me, Jay, and Stuart have all run into this problem once each, but it's hard to reproduce.  I have a hunch it may only happen the *first* time you set up Weave on Fennec; restarting and putting in your password over again seems to fix it.  I will try to reproduce with a fresh profile.

Comment 1

[Jono Xia]

To duplicate this, all I have to do is take my working profile, go to prefs.js, and delete the preference for my username.  When I start up Fennec, I can go back to the connect/setup screen and enter my credentials, but no matter what I put, Fennec gets a 401 when it tries to login to Weave.

Restarting Fennec fixes this problem.  After restart, i can go enter my credentials again and click connect, and everything works.

But why?

Comment 2

[Dan Mills [:thunder]]

The password manager uses the username to look up the password and passphrase.  If the pw manager is being created with username 'undefined' or somesuch, then after setting the username the password and passphrase would be empty.

Comment 3

[Jono Xia]

I bet the Fennec UI code is setting the username in the prefs, but not in Weave.Service.

Fix that, and also consider adding an observer to Weave.Service to observe changes in the username pref, to make sure that they can never get out of sync.

Comment 4

[Jono Xia]

Fixed in http://hg.mozilla.org/labs/weave/rev/25dc36859e03