Closed Bug 482069 Opened 11 years ago Closed 11 years ago

Awesome bar adaptiveness totally sucks

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: Mardak, Unassigned)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed by bug 476299)

Attachments

(1 obsolete file)

I've noticed that the adaptive behavior of the location bar has been pretty bad recently. Pretty sure it's related to bug 480211 in that it'll keep calling ExpireInputHistoryParanoid from ExpireOrphans on idle.

The patch in bug 476299 should fix this as it switches adaptive decay to once a day on idle instead of every time on idle.
Yeah I checked the entries in my moz_inputhistory and all the use_counts are insanely tiny like .0000001. :(
why expireinputhistoryparanoid the decay is inside expireInputHistoryParanoid? does not look like the right place for it to stay since it is not an expiration task. should be elsewhere or have his own method, imo.
Attached patch v1.0 (obsolete) — Splinter Review
This basically grabs the bits for adaptiveness from bug 476299 and pulls them here.
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Attachment #367115 - Flags: review?(mak77)
Flags: in-testsuite?
Whiteboard: [needs review mak]
Comment on attachment 367115 [details] [diff] [review]
v1.0

as Mardak pointed in IRC daily idle is trunk only, and if we are going to take daily idle on branch we can directly take the patch in bug 476299
Attachment #367115 - Flags: review?(mak77)
Attachment #367115 - Attachment is obsolete: true
ugh, yeah

OK, so this likely won't make it to 1.9.1, so I'm not going to push for it.  I'll just let this get fixed with bug 476299
Assignee: sdwilsh → nobody
Status: ASSIGNED → NEW
Whiteboard: [needs review mak]
http://hg.mozilla.org/mozilla-central/rev/d3956139b618

Won't be useful for Shiretoko though. Could do something like decay on app-quit though.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Whiteboard: fixed by bug 476299
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.