482148 - crash when serializing font-family descriptor for @font-face that doesn't have one

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Right now, if we ask for fontFaceRule.style.fontFamily on an @font-face rule that doesn't have a font-family descriptor, we crash, rather than returning the empty string.

This fixes it by checking earlier for descriptors that aren't present, so that we also don't have to check explicitly for the descriptor not being present in SerializeFontSrc.

I noticed this while writing some tests for descriptor storage and serialization (currently in test-descriptors in my patch queue at http://hg.mozilla.org/users/dbaron_mozilla.com/patches/ ) because of lack of code coverage in the output at http://people.mozilla.org/~mnandigama/codecoverage/src/layout/style/nsCSSDeclaration.cpp.gcov.html

Comment 1

[Zack Weinberg (:zwol)]

Comment on attachment 366213 [details] [diff] [review]
patch

Nice catch.  It looks like you can also remove the aResult.Truncate() call in SerializeFontSrc();

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #1)
> (From update of attachment 366213 [details] [diff] [review])
> Nice catch.  It looks like you can also remove the aResult.Truncate() call in
> SerializeFontSrc();

OK, but in that case I should rename the function to AppendFontSrc or AppendSerializedFontSrc.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/e9b0ca8dd58d

... and tested by http://hg.mozilla.org/mozilla-central/rev/1e5159da23d5

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0e5fba758c91
... with tests in http://hg.mozilla.org/releases/mozilla-1.9.1/rev/cba6fe4876e5