482161 - SaveHeaderSniffer fails to save "untitled" pages in a localizable way

Status: RESOLVED FIXED

Description

[Chris Lawson (gone)]

Created attachment 366233 [details] [diff] [review]
fix v1.0

http://mxr.mozilla.org/mozilla/source/camino/src/download/SaveHeaderSniffer.mm#282

There's a comment in the code requesting that we localize this, so I did.


Do we want to take this for 2.0?

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 366233 [details] [diff] [review]
fix v1.0

Given that an untitled document in the OS has a title of "Untitled" and a default save name suggestion of "Untitled", we should do the same thing and just use the existing string here, too.

r=me with that change.

Comment 2

[Chris Lawson (gone)]

Created attachment 366238 [details] [diff] [review]
fix v1.1

The previous patch didn't build because apparently macros don't like Obj-C syntax as input :-p

This one builds and works as expected, and addresses Smokey's other comment.

Comment 3

[Stuart Morgan]

Comment on attachment 366238 [details] [diff] [review]
fix v1.1

sr=smorgan

Comment 4

[Stuart Morgan]

(In reply to comment #2)
> The previous patch didn't build because apparently macros don't like Obj-C
> syntax as input :-p

Macros are just preprocessor string replacements, so I'm not sure what this means. Whatever problem you were having was presumably due to the fact that you were trying to use a macro designed for string literals on a method call.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.