Closed Bug 482291 Opened 15 years ago Closed 15 years ago

Implement getBrowserAtIndex() and getBrowserIndexForDocument()

Categories

(SeaMonkey :: Tabbed Browser, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(Blocks 1 open bug)

Details

(Whiteboard: firefox-parity)

Attachments

(1 file, 1 obsolete file)

We already implement getBrowserForDocument() so as a follow up we should also implement the related methods getBrowserAtIndex() and getBrowserIndexForDocument().

Google code search shows:

101 hits for getBrowserForDocument:
http://www.google.com/codesearch?as_q=getBrowserForDocument&btnG=Search+Code&hl=en&as_lang=javascrip&as_case=y

148 hits for getBrowserAtIndex:
http://www.google.com/codesearch?as_q=getBrowserAtIndex&btnG=Search+Code&hl=en&as_lang=javascrip&as_case=y

46 hits for getBrowserIndexForDocument:
http://www.google.com/codesearch?as_q=getBrowserIndexForDocument&btnG=Search+Code&hl=en&as_lang=javascrip&as_case=y

A wider search shows:

12,000,000 for getBrowserForDocument: (???)
http://www.google.com/search?&q=getBrowserForDocument&btnG=Search

834 for getBrowserAtIndex:
http://www.google.com/search?&q=getBrowserAtIndex&btnG=Search

12,300 for getBrowserIndexForDocument:
http://www.google.com/search?&q=getBrowserIndexForDocument&btnG=Search
Attached patch Patch v1.0 (obsolete) — Splinter Review
1. Implement |getBrowserForDocumentInternal| and make both |getBrowserForDocument| and |getBrowserIndexForDocument| use this.

2. Implement |getBrowserAtIndex|
Attachment #366352 - Flags: review?(neil)
Whiteboard: firefox-parity
Target Milestone: --- → seamonkey2.0b1
No longer blocks: SMtabAPI
Blocks: SMtabAPI
Comment on attachment 366352 [details] [diff] [review]
Patch v1.0

IMHO that's overkill. If you don't want to duplicate the for loop just implement getBrowserForDocument in terms of the other two.
Attachment #366352 - Flags: review?(neil) → review-
Minimal really simple brain dead patch.
Attachment #366352 - Attachment is obsolete: true
Attachment #366491 - Flags: superreview?(neil)
Attachment #366491 - Flags: review?(neil)
Attachment #366491 - Flags: superreview?(neil)
Attachment #366491 - Flags: superreview+
Attachment #366491 - Flags: review?(neil)
Attachment #366491 - Flags: review+
Comment on attachment 366491 [details] [diff] [review]
[For checkin] Patch v2.0

I see you managed to avoid copying the tab ;-)
Keywords: checkin-needed
Attachment #366491 - Attachment description: Patch v2.0 → [For checkin] Patch v2.0
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.