Closed
Bug 482296
Opened 16 years ago
Closed 16 years ago
Add attribute to nsIMsgMailNewsUrl to determine whether this is for a message
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: humph, Assigned: humph)
References
Details
Attachments
(1 file, 1 obsolete file)
1.87 KB,
patch
|
Details | Diff | Splinter Review |
Spin-off from bug 467159 comment c3: it would be nice to solve this for all callers who might have a -message url (e.g., imap-message://). After discussions on irc, the suggestion is to add a readonly attribute named isMessageUri that returns true in the case of a message uri.
Assignee | ||
Comment 1•16 years ago
|
||
I have a new patch for bug 467159 based on this that I've tested, and it works. Hopefully I've understood our discussion and done what you wanted.
Attachment #366472 -
Flags: superreview?
Attachment #366472 -
Flags: review?(bienvenu)
Assignee | ||
Updated•16 years ago
|
Attachment #366472 -
Flags: superreview? → superreview?(dmose)
Updated•16 years ago
|
Attachment #366472 -
Flags: superreview?(dmose) → superreview+
Comment 2•16 years ago
|
||
Comment on attachment 366472 [details] [diff] [review]
Patch to add isMessgeUri attribute
Please use doxygen-style comments in IDL whenever possible, even if it doesn't match local style, because that allows automated doc extraction tools to pick it up. sr=dmose with that change.
Comment 3•16 years ago
|
||
Comment on attachment 366472 [details] [diff] [review]
Patch to add isMessgeUri attribute
I think that means using /// instead of /.
I haven't tested this, because there are no callers yet, but it looks good.
Attachment #366472 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 4•16 years ago
|
||
I've updated the comment style to use /// and also modified the text slightly to match other IDL doxygen comments I found in the tree.
Attachment #366472 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 5•16 years ago
|
||
Patch checked in: http://hg.mozilla.org/comm-central/rev/e61d6cba56a1
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
Updated•16 years ago
|
Flags: in-testsuite?
Updated•10 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•