482308 - application/software update: second window pops up/pop-up, is empty/blank

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: two update windows

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090219 Calendar/1.0pre

Windows probably "forgot" the application update window last week (it does this sometimes) and now suddenly two software windows popped up: the old one as expected and the new one blank/empty, without build id, only disabled back and enabled finish and cancel buttons at the bottom.

Probably unrelated error:
Error: Component returned failure code: 0x804b0012 (NS_ERROR_UNKNOWN_PROTOCOL) [nsIXMLHttpRequest.open]
Source file: file:///F:/Software/Buero/Kalender/Sunbird/1.0-Branch/Nightly/components/nsExtensionManager.js
Line: 6533

Comment 1

[Majken Connor [:Kensie]]

I'm seeing this in Shiretoko 

current version is Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4pre) Gecko/20090316 Shiretoko/3.1b4pre 

but seeing this for a while.

Comment 2

[Robert Strong (they/them - no direct email)]

Do you know if both windows pop up at the same time or was this just the way you found it? Did you use the Help -> Check For Updates?

Comment 3

[juan becerra [:juanb]]

Weird, I'm seeing this while testing major updates (ad hoc) on Mac. I have my system set up so that it prompts me every 30 seconds for the major update offer. I clicked on "Not Now", and the second dialog appeared. In Mac the title is "Software Update" and inside it says "Introduction", with a Cancel and Done buttons available.

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Related to bug 374820?

Can you upload a screenshot, Juan?

Comment 5

[juan becerra [:juanb]]

No, I think this is something else, and the screenshots provided here are equivalent to what I see on Mac. It's update related, and not major update exclusively.

Comment 6

[Robert Strong (they/them - no direct email)]

Juan, if you are in the office right now can I come over and take a look?

Comment 7

[Majken Connor [:Kensie]]

For me they happen on their own, ie I didn't use check for updates. They don't happen every day, and I believe they come up at the same time. I'm pretty sure that's what I saw today but I can't say for certain.

Also today the second one wasn't empty.

Comment 8

[juan becerra [:juanb]]

Attachment: update log in error console

Update log, with update interval and timer set to 30 and 10 seconds, and clicking on "Not Now" button on the major udpate offer, using 3.0.7 on Mac 10.6

I also tried this on a 3.5b4nightly, with the timers changed, on Mac and Vista, but the update notification did not come up (maybe in 3.5 it's not supposed to). And the error console did not have errors similar to the ones in 3.0.7.

Comment 9

[juan becerra [:juanb]]

That attachment opens so uglily, so, again:

There was a problem with the update service URL specified, either the XML file was malformed or it does not exist at the location specified. Exception: [Exception... "'[JavaScript Error: "document.getElementById(pageid) is null" {file: "chrome://mozapps/content/update/updates.js" line: 1714}]' when calling method: [nsIUpdatePrompt::showUpdateAvailable]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Users/mozilla/Desktop/Firefox3.app/Contents/MacOS/components/nsUpdateService.js :: showPrompt :: line 3115"  data: yes]

Comment 10

[Robert Strong (they/them - no direct email)]

There can be a race condition if the timers are set to too low of a number. btw: a value of 30 in some of those prefs actually means 30 milliseconds and not 30 seconds, etc.

I've enforced a minimum value on a couple of these values that makes this for some of the cases much less likely to happen. Can you check if you are still able to reproduce?

Comment 11

[Majken Connor [:Kensie]]

I haven't been seeing the double window for a while. Sorry, I can't be more specific.

Comment 12

[Robert Strong (they/them - no direct email)]

For the case in comment #11 I've added a check for an existing app update window already open though I might not have gotten all of the cases where that could happen. I suspect that is why you haven't seen the double window in a while.

For the case in comment #3, that is less likely fixed and could happen even with the check for the update window since it can call the code to open the window multiple times before the first one is open.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Have never seen this bug again (and not touched the update checker interval).

Comment 14

[Robert Strong (they/them - no direct email)]

I'm going to go with resolving this as wfm based on the feedback from normal usage and the changes made to try to prevent this from happening. If there are ways to make it happen by changing the timers a new bug should be filed with the details as to which timers were changed and the values they were changed to. Thanks!