482318 - Toolbar icons are replicated when personas installed

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect, P1)

Description

[harvey anderson]

Attachment: screen shot

See pix attached. 
-on Fx 3.1b2
-using default Fx theme. 
-personas 1.0b3

just started about 10 days ago. 

thanks

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Yikes, that looks really bad.

I just tested Personas 1.0b3 on Firefox 3.1b2 running on Mac OS X 10.5.6, but I wasn't able to reproduce the problem.  I suppose it could be due to an incompatibility between Personas and another extension you have installed (I saw it once with the feedly extension).  If it's not too personal, could you post a list of the extensions you have enabled?

Comment 2

[Suneel]

trying to replicate with Margaret, who had a similar issue. Also checked the forums and haven't heard of this issue before. if we can reproduce, this is a P1.

Comment 3

[harvey anderson]

Attachment: addons currently installed hja

Comment 4

[harvey anderson]

Attachment: extensions currently installed hja

Comment 5

[Suneel]

this is a potential duplicate to Bug 483038 -- which produces the same result. elevating priority to a P1.

Comment 6

[Tim Riley [:timr]]

I also was this when running a nightly and demoing FFx 3.1 during CeBIT last week.  Worst time to see an ugly bug like this!

user agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090311 Shiretoko/3.1b3pre

Comment 7

[Myk Melez [:myk] [@mykmelez]]

I found the problem: we recently overrode the toolbar button icons to make them more attractive when a persona is behind them.  In the process, we accidentally overrode toolbar buttons icons that some extensions add in a way that causes the entire set of icons to display as the icon for those toolbar buttons.

I'm working on a fix that will make Personas only override toolbar button icons for the built-in Firefox toolbar buttons.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset b220f024fd66, and a new dev build has been pushed with the change:

http://people.mozilla.com/~myk/personas/dist/personas-dev.xpi

Thanks all for helping us figure out this vexing problem!

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090313 Firefox/3.1b4pre and the PDF downloader testcase! No problem anymore with the UI. Thanks Guys !