482335 - Revise Address Bar and Search Bar graphics

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect, P2)

Description

[Sean Martell]

Attachment: urlbar revised PNGs

I've revised the PNGs for the address bar and search bar to better match the new toolbar.png buttons.

Once implemented, I may have to tweak one or two, but I'll need to see them inside the browser first.

Comment 1

[Sean Martell]

Note:  these have been designed to be put in at 100% instead of the current Personas build where their opacity has been set below 100%.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I've committed these to my local repository and spun a dev build with them, but I haven't yet pushed the changes to the central repository, as I'm not sure they're working correctly yet.  Please check out the dev build and let me know how they work for you:

http://people.mozilla.com/~myk/personas/dist/personas-dev.xpi

Also, note that I've added these images in a way that makes these images get used whether or not the user has selected a persona.  In other words, they get used even when the user has selected the "default" persona (i.e. no persona at all, just the regular Firefox theme).

Hopefully that's ok.  Making them apply only when a persona is selected is more complicated, although it is doable.

Comment 3

[Chris Beard]

Attachment: screenshot showing address bar background issue

look pretty good to me.  only problem i see is that on the address bar the right-hand side of the time includes a background colour inside the curve that looks a bit wrong.  is it possible to make that part of the image transparent?

Comment 4

[Chris Beard]

s/time/image

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Note: the dev build no longer contains these changes.  In discussions with Sean on IRC, we agreed to hold off committing them, as there are some issues with the way they look, and it's not clear what is causing those issues.

Comment 6

[Suneel]

discussed with sean. we will be allocating time to this during the all-hands meeting in April. changing status to P2.

Comment 7

[Ryan Doherty (:rdoherty)]

This is fixed in Firefox 3.6.